New issue
Advanced search Search tips

Issue 753335 link

Starred by 1 user
Status: Assigned
Owner:
edchin@chromium.org
Cc:
marq@chromium.org
ios-bugs@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add DnD to the iPad's tab strip

Project Member Reported by jif@chromium.org, Aug 8 2017 
dragging to a tab strip should replace the content of the tab with whatever was in the drag.
dragging to the [new tab] button in the tab strip should create a new tab with whatever content was in the drag.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54c1fe26e90cc126b95b733d65d6d6e19739b98

commit d54c1fe26e90cc126b95b733d65d6d6e19739b98
Author: Jean-François Geyelin <jif@chromium.org>
Date: Thu Aug 17 11:25:24 2017

[iOS] Add drag-and-drop support to the iPad tab strip.

Dropping something on the New Tab Button creates a new tab.
Dropping something on a Tab results in a navigation in the said tab.

This CL changes the TabView => TabStripController communication:
The TabView now communicates events to its TabViewDelegate.
The TabStripController implements TabViewDelegate.

Bug: 753335
Change-Id: I14a589e831af19289e55e324ed11b987ecc5ae7f
Reviewed-on: https://chromium-review.googlesource.com/610049
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495137}
[modify] https://crrev.com/d54c1fe26e90cc126b95b733d65d6d6e19739b98/ios/chrome/browser/ui/tabs/BUILD.gn
[modify] https://crrev.com/d54c1fe26e90cc126b95b733d65d6d6e19739b98/ios/chrome/browser/ui/tabs/tab_strip_controller.h
[modify] https://crrev.com/d54c1fe26e90cc126b95b733d65d6d6e19739b98/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/d54c1fe26e90cc126b95b733d65d6d6e19739b98/ios/chrome/browser/ui/tabs/tab_view.h
[modify] https://crrev.com/d54c1fe26e90cc126b95b733d65d6d6e19739b98/ios/chrome/browser/ui/tabs/tab_view.mm
[add] https://crrev.com/d54c1fe26e90cc126b95b733d65d6d6e19739b98/ios/chrome/browser/ui/tabs/tab_view_delegate.h

Comment 2 by eugene...@chromium.org, Jun 22 2018

Owner: ----
Status: Untriaged (was: Assigned)
jif@ is no longer on the team. Releasing his bugs.

Comment 3 by olivierrobin@chromium.org, Jun 22 2018

Cc: marq@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)
►

Sign in to add a comment