Tests SadTabTabHelperTest.* failing on devices on downstream bots |
||||||
Issue descriptionBuilders failed on: - ipad10-device-x64: http://master7.golo.chromium.org/i/internal.bling.main/builders/ipad10-device-x64 - iphone10-device-x64: http://master7.golo.chromium.org/i/internal.bling.main/builders/iphone10-device-x64 - iphone9-device-x64: http://master7.golo.chromium.org/i/internal.bling.main/builders/iphone9-device-x64 - smoke: http://master7.golo.chromium.org/i/internal.bling.main/builders/smoke The following tests are consistently failing on device bots: SadTabTabHelperTest.Presented SadTabTabHelperTest.RepeatedFailuresShowCorrectUI SadTabTabHelperTest.FailureInterval This started with roll to 9807235c73e7b63ad4c8ef9a8d26d1ef2df98c92 from 97d44ba209974fa0340cbf70de51d79ef2eb4849. So this includes the following CLs: $ git log --oneline 97d44ba209974fa0340cbf70de51d79ef2eb4849...9807235c73e7b63ad4c8ef9a8d26d1ef2df98c92 9807235c73e7 cros: Migrate system tray caps lock prefs code into ash 67e76f02ed68 cc: Add presubmit that IPC should be updated with mojo 13b9afd5435e Use real surface in ArcNotificationContentViewTest 98be3272d43c Turn OutOfBlinkCORS blink runtime enabled flag into chrome feature 036fd1f21f7a disk_cache: Add an API for synchronizing with post-backend dtor I/O; also automatically sequence new creation of backends for a path after completion of destruction of previous backends for that path. 2ccc2f573320 Fix typos in TabManager swap metrics histograms 9687abb7f328 Omnibox UI Experiments: Fix HistoryURLProvider match text classification 280223f141c2 Remove use of BrowserThead::FILE from ChromeBrowsingDataRemoverDelegate. 97a5a4ae3383 Add spinner when fetching more suggestions 661447753dd7 ES6 JS styleguide: Whitelist new Object, Array and Number properties/methods. 46259371ebc4 Removed SadTabTabHelperDelegate. 0ff197f9fe95 mash: Fix ShellObserver::OnActiveUserPrefServiceChanged semantics be39b6a46ff6 Stop adding RawResources to MemoryCache a895183ec919 [LayoutNG] Add style/text to NGPhysicalTextFragment for :first-line 19e8a73f10a1 Removing dummy states is causing strange input selection test failures 69e64e136584 [Chromecast] Disable loopback thread when unneeded I suspect CL "46259371ebc4 Removed SadTabTabHelperDelegate" => eugenebut.
,
Aug 8 2017
,
Aug 8 2017
Marking as RBS as this correspond to disabled tests.
,
Aug 8 2017
This is quite an interesting case. Tests are not failing locally if I run on iPhone SE, iOS 10.3, but ios_chrome_unittest suite is DCHECKing in autofill tests. Removing RBS, because the test is only disabled on device.
,
Aug 8 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de6b73a260f1f11e88d9497befbefece1fd71af7 commit de6b73a260f1f11e88d9497befbefece1fd71af7 Author: Eugene But <eugenebut@google.com> Date: Thu Aug 10 23:32:17 2017 Fixed SadTabTabHelperTest tests. Mock UIApplication.sharedApplication.applicationState so the test does not rely on specific app state. Also added two more tests: SadTabTabHelperTest.AppInBackground, SadTabTabHelperTest.AppIsInactive. Bug: 753327 Change-Id: I85718f6101e6a6d2a8c240935d3a620b24595858 Reviewed-on: https://chromium-review.googlesource.com/607367 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#493597} [modify] https://crrev.com/de6b73a260f1f11e88d9497befbefece1fd71af7/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/de6b73a260f1f11e88d9497befbefece1fd71af7/ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
,
Aug 11 2017
Issue 754650 has been merged into this issue.
,
Aug 11 2017
Issue 754740 has been merged into this issue.
,
Aug 19 2017
,
Jan 24 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 8 2017