New issue
Advanced search Search tips

Issue 753325 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 750684
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT import] Import failed due to TestExpectations lint failure

Project Member Reported by foolip@chromium.org, Aug 8 2017

Issue description

https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/440

This job failed like this:

Lines to write to TestExpectations:
  crbug.com/626703 [ Android Mac Win ] external/wpt/http/basic-auth-cache-test.html [ Crash ]
  crbug.com/626703 [ Android Mac10.10 Win ] external/wpt/http/content_length.html [ Skip ]
  crbug.com/626703 [ Android Mac10.11 Mac10.12 Mac10.9 Retina Win ] external/wpt/http/content_length.html [ Crash ]
  crbug.com/626703 [ Android Mac10.10 Mac10.11 Mac10.12 Retina Win ] virtual/enable_wasm/external/wpt/wasm/wasm_indexeddb_test.html [ Crash ]
  crbug.com/626703 [ Android Mac Win ] virtual/enable_wasm/external/wpt/wasm/wasm_local_iframe_test.html [ Crash ]
  crbug.com/626703 [ Android Mac10.9 Win ] virtual/enable_wasm/external/wpt/wasm/wasm_serialization_tests.html [ Skip ]
  crbug.com/626703 [ Android Mac10.10 Mac10.11 Mac10.12 Retina Win ] virtual/enable_wasm/external/wpt/wasm/wasm_serialization_tests.html [ Crash ]
  crbug.com/626703 [ Android Mac10.10 Mac10.11 Mac10.12 Retina Win ] virtual/enable_wasm/external/wpt/wasm/wasm_service_worker_test.https.html [ Crash ]
Generating MANIFEST.json
Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 125, in main
    if not self.update_expectations_for_cl():
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 161, in update_expectations_for_cl
    self._upload_patchset(message)
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 381, in _upload_patchset
    self.git_cl.run(['upload', '-f', '-t', message, '--gerrit'])
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 51, in run
    return self._host.executive.run_command(command, cwd=self._cwd)
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 339, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/data/b/rr/tmpJF8Ojx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 247, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'upload', '-f', '-t', 'Update test expectations and baselines.', '--gerrit']" exit_code: 1
output: Last 500 characters of output:
atch overlapping sets of configurations. external/wpt/http/content_length.html
third_party/WebKit/LayoutTests/TestExpectations:1778 Entries for virtual/enable_wasm/external/wpt/wasm/wasm_serialization_tests.html on lines third_party/WebKit/LayoutTests/TestExpectations:1777 and third_party/WebKit/LayoutTests/TestExpectations:1778 match overlapping sets of configurations. virtual/enable_wasm/external/wpt/wasm/wasm_serialization_tests.html
Lint failed.
 
Labels: -Pri-3 Pri-1
qyearsley@, robertma@, can either of you self-assign this? There's already been a successful import today, but probably there won't be one tomorrow if this happens again.
An interesting detail is that https://chromium-review.googlesource.com/c/604878 didn't have any changes, which means that the expectations that we tried to add here ought to be due to a transient problem (perhaps reverted by sheriff) or flakiness. Can anything be done to prevent a build-up of these kinds of expectations over time?
Mergedinto: 750684
Status: Duplicate (was: Untriaged)
Yep, this something that will eventually cause import failures in the future (possibly mostly transient). Duping into 750684.

Sign in to add a comment