New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753322 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'Join Wi-Fi Network' overlay is displayed on clicking on Add other mobile network link in 'Connect to Network' screen.

Project Member Reported by jbanavatu@chromium.org, Aug 8 2017

Issue description

Chrome Version: 61.0.3163.38/9765.21.0 dev channel Daisy,Minnie,Jerry,Peppy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build via USB >> Navigate to 'Connect to Network' screen.
(2)Now click on 'Add other mobile network' link present at the bottom and Observe.

Expected: 'Choose a mobile network' overlay should be seen on clicking on Other mobile networks link
Actual: Instead, Unnecessary 'Join Wi-Fi Network' overlay is displayed.

This is regression issue as same is working fine in M58.

Note:
1.Issue also seen in latest M-62
2.Issue is not applicable to Linux and Windows OS

Attaching screen-cast for reference.
 
Actual.mp4
9.0 MB View Download
Expected.mp4
10.1 MB View Download
Cc: alemate@chromium.org
Owner: steve...@chromium.org
Labels: -M-62 ReleaseBlock-Stable M-60
This is bad. We should really backport the fix to 60. It's a trivial one line change.

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60df28a4cd9854f789e33928d93c227991051ba6

commit 60df28a4cd9854f789e33928d93c227991051ba6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Aug 17 00:11:19 2017

OOBE: Network: Fix 'Add other mobile'

Bug:  753322 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I560abad0ab99b8995fa0b0a71a975f222f5a08d1
Reviewed-on: https://chromium-review.googlesource.com/618121
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495007}
[modify] https://crrev.com/60df28a4cd9854f789e33928d93c227991051ba6/chrome/browser/resources/chromeos/login/oobe_welcome.js

Labels: Merge-Request-60
This is a very simple fix to a very bad bug for the handful of affected people.

Status: Fixed (was: Started)
Cc: josa...@chromium.org
Ping. This bug is really quite bad and a very simple fix.
Cc: keta...@chromium.org
Labels: -M-60 -Merge-Request-60 M-61 Merge-Request-61
Guess we missed the boat on 60, which is unfortunate.

We should really really merge this to 61.

Ping.

Project Member

Comment 10 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-62 Merge-Approved-61
Approving merge to M61 and M62.
Labels: -Merge-Approved-62
Merge to 62 isn't necessary, this landed on Aug 17 @#495007.

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 13 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71956796c951eb12a31eaa9df15bc2eaec8b038d

commit 71956796c951eb12a31eaa9df15bc2eaec8b038d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Sep 13 20:52:50 2017

OOBE: Network: Fix 'Add other mobile'

TBR=stevenjb@chromium.org

(cherry picked from commit 60df28a4cd9854f789e33928d93c227991051ba6)

Bug:  753322 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I560abad0ab99b8995fa0b0a71a975f222f5a08d1
Reviewed-on: https://chromium-review.googlesource.com/618121
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495007}
Reviewed-on: https://chromium-review.googlesource.com/665758
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1189}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/71956796c951eb12a31eaa9df15bc2eaec8b038d/chrome/browser/resources/chromeos/login/oobe_welcome.js

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment