Gerrit: perf_try support for feature branches |
||
Issue descriptionWhen running a perf_try job on a feature branch, the patch seems to be applied on top of origin/master HEAD instead of on the base of the feature branch. Checking the output of the failed perf_try job on this feature branch CL ( https://chromium-review.googlesource.com/c/600667/7 ), the patch seems to fail because of a merge conflict, which should never be the case on a feature branch. An additional advantage of comparing the CL with the base of the feature branch, is that the only differences in the code should come from the CL, and the benchmark comparison will be affected only by changes in the CL.
,
Aug 8 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/3b8e064102f5a4d9daa287e22feae3442714a80f commit 3b8e064102f5a4d9daa287e22feae3442714a80f Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Aug 08 11:35:24 2017
,
Aug 8 2017
FYI: Better fix in flight: https://chromium-review.googlesource.com/c/605609
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c14b4f1518dfd0bf57c27d42b28abdc9252145ef commit c14b4f1518dfd0bf57c27d42b28abdc9252145ef Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Aug 09 09:37:58 2017 Fix bot_update default value for empty revision Bug: 753297 Change-Id: I31c031ce1efa3a1a7d30fd7eeb71d3e4b3baa720 Reviewed-on: https://chromium-review.googlesource.com/605609 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [add] https://crrev.com/c14b4f1518dfd0bf57c27d42b28abdc9252145ef/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_empty_revision.json [modify] https://crrev.com/c14b4f1518dfd0bf57c27d42b28abdc9252145ef/recipes/recipe_modules/bot_update/examples/full.py [modify] https://crrev.com/c14b4f1518dfd0bf57c27d42b28abdc9252145ef/recipes/README.recipes.md [modify] https://crrev.com/c14b4f1518dfd0bf57c27d42b28abdc9252145ef/recipes/recipe_modules/bot_update/api.py
,
Aug 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by machenb...@chromium.org
, Aug 8 2017Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)