New issue
Advanced search Search tips

Issue 753289 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 679977



Sign in to add a comment

LastOffsetForEditing should return 0 for empty Node.

Project Member Reported by yoichio@chromium.org, Aug 8 2017

Issue description

It returns 1 historically but no one understand why and it is not
 straight forward that <br> returns 1.
 

Comment 1 Deleted

Comment 2 by yosin@chromium.org, Aug 9 2017

Here is list of failed layout test when changing LastOffsetForEditing() to return
0 for elements w/o child nodes with change of IsVisuallyEquivalentCandidate().

List: https://goo.gl/6zLiu6

Sample patch: http://crrev.com/c/607730

Comment 3 by yosin@chromium.org, Aug 9 2017

Blocking: 679977

Comment 4 by yosin@chromium.org, Aug 9 2017

Blockedon: 679977
Blocking: -679977
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d8f5635b6f6ef607e162c4517d17376b2b897e

commit 17d8f5635b6f6ef607e162c4517d17376b2b897e
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Aug 10 05:47:46 2017

Converts editing/execCommand/19653-{1,2}.html to utilize assert_selection()

This patch converts "editing/execCommand/19653-{1,2}.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename
to "keep_typing_style.html" to provide a hint of what this test script, for
improving code health.

Bug: 753289, 679977
Change-Id: Id013e7953511f0f982b8f58191c474ebffc2f8fb
Reviewed-on: https://chromium-review.googlesource.com/607752
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493300}
[modify] https://crrev.com/17d8f5635b6f6ef607e162c4517d17376b2b897e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/182abef7308732fa392d65b000cb52fff45a88fb/third_party/WebKit/LayoutTests/editing/execCommand/19653-1-expected.txt
[delete] https://crrev.com/182abef7308732fa392d65b000cb52fff45a88fb/third_party/WebKit/LayoutTests/editing/execCommand/19653-1.html
[delete] https://crrev.com/182abef7308732fa392d65b000cb52fff45a88fb/third_party/WebKit/LayoutTests/editing/execCommand/19653-2-expected.txt
[delete] https://crrev.com/182abef7308732fa392d65b000cb52fff45a88fb/third_party/WebKit/LayoutTests/editing/execCommand/19653-2.html
[add] https://crrev.com/17d8f5635b6f6ef607e162c4517d17376b2b897e/third_party/WebKit/LayoutTests/editing/execCommand/keep_typing_style.html

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3961af959ee3a17b750b692ed2f18aca1283f1d1

commit 3961af959ee3a17b750b692ed2f18aca1283f1d1
Author: Akari Asai <akariasai@google.com>
Date: Thu Aug 10 06:33:02 2017

Converts editing/execCommand/5483526.html to utilize assert_selection().

This patch converts "editing/execCommand/5483526.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename to
"selection-table-with-empty-cells.html" to provide a hint of
what this test script, for improving code health.

Bug: 753289
Change-Id: I91252308db8be8a8448601e58a04a594b788ba47
Reviewed-on: https://chromium-review.googlesource.com/608985
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493309}
[modify] https://crrev.com/3961af959ee3a17b750b692ed2f18aca1283f1d1/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/dc8f0150b4eda2cc5cdd0e831216bc741bb12bcc/third_party/WebKit/LayoutTests/editing/execCommand/5483526-expected.txt
[delete] https://crrev.com/dc8f0150b4eda2cc5cdd0e831216bc741bb12bcc/third_party/WebKit/LayoutTests/editing/execCommand/5483526.html
[add] https://crrev.com/3961af959ee3a17b750b692ed2f18aca1283f1d1/third_party/WebKit/LayoutTests/editing/execCommand/selection_table_with_empty_cells.html

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64856c51438e3a60c2b5bfc364212f4a63307e32

commit 64856c51438e3a60c2b5bfc364212f4a63307e32
Author: Akari Asai <akariasai@google.com>
Date: Thu Aug 10 07:07:59 2017

Converts editing/execCommand/19455.html to utilize assert_selection().

This patch converts "editing/execCommand/19455.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename to
"check_justify_center_performance.html" to provide a hint of
what this test script, for improving code health.

Bug: 753289
Change-Id: Ia114592277f50914f4d2e52aba24462013dfe721
Reviewed-on: https://chromium-review.googlesource.com/607809
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493315}
[delete] https://crrev.com/0c80ba27ce0942996dbed1e4f57129475492f37a/third_party/WebKit/LayoutTests/editing/execCommand/19455-expected.txt
[delete] https://crrev.com/0c80ba27ce0942996dbed1e4f57129475492f37a/third_party/WebKit/LayoutTests/editing/execCommand/19455.html
[add] https://crrev.com/64856c51438e3a60c2b5bfc364212f4a63307e32/third_party/WebKit/LayoutTests/editing/execCommand/check_justify_center_performance.html

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ba2427892a89bb295a19cc1c90ae0f73964735f

commit 8ba2427892a89bb295a19cc1c90ae0f73964735f
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Aug 10 07:49:18 2017

Converts editing/execCommand/crash-line-break-after-outdent.html to utilize assert_selection()

This patch converts "editing/execCommand/crash-line-break-after-outdent.html" to
utilize |assert_selection()| for ease of maintaining this test script for
improving code health.

Bug: 753289, 679977
Change-Id: Id263a61feff9aaf7779dcd893e4f4f6fda8f019e
Reviewed-on: https://chromium-review.googlesource.com/609567
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493322}
[delete] https://crrev.com/be769dc175dd75910ba155af1c51043f9b277ee5/third_party/WebKit/LayoutTests/editing/execCommand/crash-line-break-after-outdent-expected.txt
[modify] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/editing/execCommand/crash-line-break-after-outdent.html

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fae6ccd824ba69f66e6abdcdd262d07262de7aa

commit 2fae6ccd824ba69f66e6abdcdd262d07262de7aa
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Aug 10 07:49:24 2017

Converts editing/execCommand/{4747450,4917055}.html to utilize assert_selection()

This patch converts "editing/execCommand/{4747450,4917055}.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename to
"insert_no_hang.html" to provide a hint of what this test script, for
improving code health.

Bug: 753289, 679977
Change-Id: Idebfd33232dbb4caf8c9338cb0e5d2db69d000c0
Reviewed-on: https://chromium-review.googlesource.com/607838
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493323}
[modify] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/editing/execCommand/4747450.html
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/editing/execCommand/4917055-expected.txt
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/editing/execCommand/4917055.html
[add] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/editing/execCommand/insert_list/insert_list_no_hang.html
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/4747450-expected.png
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/4747450-expected.txt
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/4747450-expected.png
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/4747450-expected.txt
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/4747450-expected.png
[delete] https://crrev.com/8ba2427892a89bb295a19cc1c90ae0f73964735f/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/4747450-expected.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a20c03d0bb95a4b6e1ba36787f45c02ac7e6f8d

commit 5a20c03d0bb95a4b6e1ba36787f45c02ac7e6f8d
Author: Akari Asai <akariasai@google.com>
Date: Thu Aug 10 07:52:19 2017

Converts editing/execCommand/5136770.html to utilize assert_selection().

This patch converts "editing/execCommand/5136770.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename to
"insert_unordered_list.html" to provide a hint of
what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: I919e3dc5c876230144749a414e72406f3feae345
Reviewed-on: https://chromium-review.googlesource.com/609342
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493324}
[modify] https://crrev.com/5a20c03d0bb95a4b6e1ba36787f45c02ac7e6f8d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/editing/execCommand/5136770.html
[add] https://crrev.com/5a20c03d0bb95a4b6e1ba36787f45c02ac7e6f8d/third_party/WebKit/LayoutTests/editing/execCommand/insert_unordered_list.html
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/5136770-expected.png
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/5136770-expected.txt
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/5136770-expected.png
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/5136770-expected.txt
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/5136770-expected.png
[delete] https://crrev.com/2fae6ccd824ba69f66e6abdcdd262d07262de7aa/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/5136770-expected.txt

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c80abd336407521d340d627fa81f4e166bc8b17b

commit c80abd336407521d340d627fa81f4e166bc8b17b
Author: Akari Asai <akariasai@google.com>
Date: Mon Aug 14 09:49:00 2017

Converts editing/execCommand/insert-list-empty-div.html to utilize assert_selection().

This patch converts "editing/execCommand/insert-list-empty-div.html"
to utilize |assert_selection()| for ease of maintaining this test script
and rename to "insert_list_empty_div.html"
for improving code health.


Bug: 753289
Change-Id: I60790bcd84ab257bfb65c13302318a60735025d7
Reviewed-on: https://chromium-review.googlesource.com/612961
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Akari Asai <akariasai@google.com>
Cr-Commit-Position: refs/heads/master@{#494026}
[modify] https://crrev.com/c80abd336407521d340d627fa81f4e166bc8b17b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/ff6179ee517e2db9ac19ed0cfe8617012f632d30/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-empty-div-expected.txt
[delete] https://crrev.com/ff6179ee517e2db9ac19ed0cfe8617012f632d30/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-empty-div.html
[add] https://crrev.com/c80abd336407521d340d627fa81f4e166bc8b17b/third_party/WebKit/LayoutTests/editing/execCommand/insert_list_empty_div.html

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975d576f7ed1e18d512845dde986dd0923b842b6

commit 975d576f7ed1e18d512845dde986dd0923b842b6
Author: Akari Asai <akariasai@google.com>
Date: Tue Aug 15 10:45:12 2017

Converts editing/execCommand/insert-list-in-noneditable-list-parent.html to utilize assert_selection().

This patch converts "editing/execCommand/insert-list-in-noneditable-list-parent.html"
to utilize |assert_selection()| for ease of maintaining this test script
and rename to "insert_list_in_noneditable_list_parent.html"
for improving code health.

Bug: 753289
Change-Id: I805ca0b0be6f022c51b1da7620541fada1aeb884
Reviewed-on: https://chromium-review.googlesource.com/612927
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494357}
[modify] https://crrev.com/975d576f7ed1e18d512845dde986dd0923b842b6/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/fc55a9d866626a697c16375a9b2084e309f85a51/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt
[delete] https://crrev.com/fc55a9d866626a697c16375a9b2084e309f85a51/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent.html
[add] https://crrev.com/975d576f7ed1e18d512845dde986dd0923b842b6/third_party/WebKit/LayoutTests/editing/execCommand/insert_list_in_noneditable_list_parent.html

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71d20ab63d64c7e21051fb33a01faa0e815849c

commit b71d20ab63d64c7e21051fb33a01faa0e815849c
Author: Akari Asai <akariasai@google.com>
Date: Wed Aug 16 06:11:30 2017

Converts editing/execCommand/5080333-{1, 2}.html to utilize assert_selection().

This patch converts "editing/execCommand/5136770.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename to
"selection_image_alignment_change.html" to provide a hint of
what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: I713e9d82970af8b65a36ab41faccd431c7c01dac
Reviewed-on: https://chromium-review.googlesource.com/608992
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Akari Asai <akariasai@google.com>
Cr-Commit-Position: refs/heads/master@{#494705}
[delete] https://crrev.com/97156ad7e3aaf12a766c5e69d457ad15f492690b/third_party/WebKit/LayoutTests/editing/execCommand/5080333-1.html
[delete] https://crrev.com/97156ad7e3aaf12a766c5e69d457ad15f492690b/third_party/WebKit/LayoutTests/editing/execCommand/5080333-2.html
[add] https://crrev.com/b71d20ab63d64c7e21051fb33a01faa0e815849c/third_party/WebKit/LayoutTests/editing/execCommand/selection_image_after_alignment_change.html

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93ecf9e5694aa3feed507e4a055fa8a613538c64

commit 93ecf9e5694aa3feed507e4a055fa8a613538c64
Author: Akari Asai <akariasai@google.com>
Date: Wed Aug 16 06:12:38 2017

Converts editing/execCommand/insert-ordered-list.html to utilize assert_selection()

This patch converts "editing/execCommand/insert-ordered-list.html"
to utilize |assert_selection()| for ease of maintaining this test
script and rename to "insert_ordered_list.html"
to provide a hint of what this test script, for improving code health.

Converted insert_ordered list.

Bug: 753289
Change-Id: I61e94415e544246da1bad1ac20833f394b1bf299
Reviewed-on: https://chromium-review.googlesource.com/612930
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Akari Asai <akariasai@google.com>
Cr-Commit-Position: refs/heads/master@{#494706}
[delete] https://crrev.com/b71d20ab63d64c7e21051fb33a01faa0e815849c/third_party/WebKit/LayoutTests/editing/execCommand/insert-ordered-list-expected.txt
[delete] https://crrev.com/b71d20ab63d64c7e21051fb33a01faa0e815849c/third_party/WebKit/LayoutTests/editing/execCommand/insert-ordered-list.html
[add] https://crrev.com/93ecf9e5694aa3feed507e4a055fa8a613538c64/third_party/WebKit/LayoutTests/editing/execCommand/insert_ordered_list.html

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f759da5199bcdd420f8dfdff506e35f3c0bb5464

commit f759da5199bcdd420f8dfdff506e35f3c0bb5464
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Aug 17 12:44:45 2017

Converts editing/execCommand/5469868.html to utilize assert_selection().

This patch converts "editing/execCommand/5469868.html" to utilize
|assert_selection()| for ease of maintaining this test script and rename to
"insert_list_table_no_hang.html" to provide a hint of
what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: I7757ff2bbb41bcf8ed9700cfcd60a9e189b11f6a
Reviewed-on: https://chromium-review.googlesource.com/609823
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495153}
[modify] https://crrev.com/f759da5199bcdd420f8dfdff506e35f3c0bb5464/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/a5b0e30df7b1d6ab67bf867c7a20d9193170d841/third_party/WebKit/LayoutTests/editing/execCommand/5469868-expected.txt
[delete] https://crrev.com/a5b0e30df7b1d6ab67bf867c7a20d9193170d841/third_party/WebKit/LayoutTests/editing/execCommand/5469868.html
[add] https://crrev.com/f759da5199bcdd420f8dfdff506e35f3c0bb5464/third_party/WebKit/LayoutTests/editing/execCommand/insert_list/insert_list_table_no_hang.html

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4489b80312d3e8f319e5abd5fea885e0597fa95b

commit 4489b80312d3e8f319e5abd5fea885e0597fa95b
Author: Akari Asai <akariasai@google.com>
Date: Fri Aug 18 02:32:50 2017

Converts editing/execCommand/insert-list-infinite-loop2.html to utilize assert_selection()

This patch converts "editing/execCommand/insert-list-infinite-loop2.html"
to utilize |assert_selection()| for ease of maintaining this test
script to provide a hint of what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: Ic596173238dfd34fa6dcdf40eef093074ae45183
Reviewed-on: https://chromium-review.googlesource.com/618406
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Akari Asai <akariasai@google.com>
Cr-Commit-Position: refs/heads/master@{#495432}
[modify] https://crrev.com/4489b80312d3e8f319e5abd5fea885e0597fa95b/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-infinite-loop2.html

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74c06191951512f879c37939e9f0f24ed4550aee

commit 74c06191951512f879c37939e9f0f24ed4550aee
Author: Akari Asai <akariasai@google.com>
Date: Mon Aug 21 02:42:59 2017

Converts editing/execCommand/list-wrapping-image-crash.html to utilize assert_selection().

This patch converts "editing/execCommand/list-wrapping-image-crash.html"
to utilize |assert_selection()| for ease of maintaining this test
script to provide a hint of what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: I499a669165d61f8644bcf62fca3d71f9b4d9b027
Reviewed-on: https://chromium-review.googlesource.com/620329
Commit-Queue: Akari Asai <akariasai@google.com>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495862}
[delete] https://crrev.com/2075c7ed7438b0b0796f29ec3a88e14ffeba51ff/third_party/WebKit/LayoutTests/editing/execCommand/list-wrapping-image-crash-expected.txt
[modify] https://crrev.com/74c06191951512f879c37939e9f0f24ed4550aee/third_party/WebKit/LayoutTests/editing/execCommand/list-wrapping-image-crash.html

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b77df562643f733dfed3609ff8c85894a2e501

commit 07b77df562643f733dfed3609ff8c85894a2e501
Author: Akari Asai <akariasai@google.com>
Date: Fri Aug 25 03:30:36 2017

Converted insert-list-with-progress-crash.html to utilize assert_selection().

This patch converts "insert-list-with-progress-crash.html" to utilize
|assert_selection()| for ease of maintaining and for improving code health.

Bug: 753289, 679977
Change-Id: Ib5a99b473dc2efdcf9ff42e0127f957020de43f0
Reviewed-on: https://chromium-review.googlesource.com/628618
Commit-Queue: Akari Asai <akariasai@google.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497312}
[modify] https://crrev.com/07b77df562643f733dfed3609ff8c85894a2e501/third_party/WebKit/LayoutTests/editing/execCommand/insert-list-with-progress-crash.html

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2bdc4bc82735887398e448603b70c7e03917b57

commit e2bdc4bc82735887398e448603b70c7e03917b57
Author: Akari Asai <akariasai@google.com>
Date: Wed Aug 30 12:05:45 2017

Converts editing/execCommand/list-wrapping-image-crash.html to utilize assert_selection().

This patch converts "editing/execCommand/insert-paragraph-into-table.html"
to utilize |assert_selection()| for ease of maintaining this test
script to provide a hint of what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: I5d5af3e1fbed930b35ce8d0b9f8c8a7b97271364
Reviewed-on: https://chromium-review.googlesource.com/632197
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498428}
[modify] https://crrev.com/e2bdc4bc82735887398e448603b70c7e03917b57/third_party/WebKit/LayoutTests/editing/execCommand/insert-paragraph-into-table.html

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91eb2ca4c4da682157b38521495f9ff7b1e2b25a

commit 91eb2ca4c4da682157b38521495f9ff7b1e2b25a
Author: Akari Asai <akariasai@google.com>
Date: Wed Sep 06 03:08:26 2017

Converted switch-multiple-list-items-crash.html to utilize assert_selection().

This patch converts "switch-multiple-list-items-crash.html" to utilize
|assert_selection()| for ease of maintaining and for improving code health.

Bug: 753289, 679977
Change-Id: Ibb93c97f1871d32228c0d3b38479f163f1e18834
Reviewed-on: https://chromium-review.googlesource.com/649451
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Akari Asai <akariasai@google.com>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499866}
[delete] https://crrev.com/f227110f19e30a20509488005f8c6cb29f157833/third_party/WebKit/LayoutTests/editing/execCommand/switch-multiple-list-items-crash-expected.txt
[modify] https://crrev.com/91eb2ca4c4da682157b38521495f9ff7b1e2b25a/third_party/WebKit/LayoutTests/editing/execCommand/switch-multiple-list-items-crash.html

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5913eeddd2cc06a64d07977173639835568670b6

commit 5913eeddd2cc06a64d07977173639835568670b6
Author: Akari Asai <akariasai@google.com>
Date: Thu Sep 14 03:55:52 2017

Converts editing/execCommand/inserting-ordered-list-crash.html to utilize assert_selection().

This patch converts "editing/execCommand/inserting-ordered-list-crash.html"
to utilize |assert_selection()| for ease of maintaining this test
script to provide a hint of what this test script, for improving code health.

Bug: 753289, 679977
Change-Id: I0e70d204fbd6ee9350e5361a475f8b5080921dc8
Reviewed-on: https://chromium-review.googlesource.com/664738
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501863}
[delete] https://crrev.com/6071701f1276591080573f7b11617dd1177e159f/third_party/WebKit/LayoutTests/editing/execCommand/inserting-ordered-list-crash-expected.txt
[modify] https://crrev.com/5913eeddd2cc06a64d07977173639835568670b6/third_party/WebKit/LayoutTests/editing/execCommand/inserting-ordered-list-crash.html

Comment 22 by yosin@chromium.org, Jan 10 2018

Labels: Pri-3
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment