New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753287 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Direct reply doesn't work in the message center

Project Member Reported by yoshiki@chromium.org, Aug 8 2017

Issue description

Now, the message center is not activatable by default, so that the direct reply is not working: key-events are not sent to Android correctly. We need to make the message center activatable and active before user uses the direct reply.

This change is the cause of this regression:
https://codereview.chromium.org/2897553002/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111

commit 5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Tue Aug 08 19:13:46 2017

Activate Widget and Focus SurfaceWindow when DirectInput is used

With the recent change (crrev.com/2897553002), the message center is not activatable by default, so that the direct reply was not working: key-events were not sent to Android correctly. This patch makes the message center activatable and active before user uses the direct reply.

Bug:  753287 
Change-Id: Ib34db94e03e78f136a52ae2850551bf968b9c9e4
Reviewed-on: https://chromium-review.googlesource.com/604644
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492721}
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/arc/notification/arc_notification_content_view.h
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/arc/notification/arc_notification_surface.h
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/arc/notification/arc_notification_surface_impl.cc
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/arc/notification/arc_notification_surface_impl.h
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111/ui/message_center/views/toast_contents_view.h

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 10 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I confirmed it's working on 62.0.3174.0 canary

Comment 5 by ketakid@google.com, Aug 10 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0479d3a76a8fe5455277966346ff6f099ed599a0

commit 0479d3a76a8fe5455277966346ff6f099ed599a0
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Aug 10 17:19:09 2017

Activate Widget and Focus SurfaceWindow when DirectInput is used

With the recent change (crrev.com/2897553002), the message center is not activatable by default, so that the direct reply was not working: key-events were not sent to Android correctly. This patch makes the message center activatable and active before user uses the direct reply.

TBR=yoshiki@chromium.org

(cherry picked from commit 5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111)

Bug:  753287 
Change-Id: Ib34db94e03e78f136a52ae2850551bf968b9c9e4
Reviewed-on: https://chromium-review.googlesource.com/604644
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492721}
Reviewed-on: https://chromium-review.googlesource.com/610640
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#434}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_content_view.h
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_surface.h
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_surface_impl.cc
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_surface_impl.h
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/message_center/views/toast_contents_view.h

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment