Direct reply doesn't work in the message center |
|||||||
Issue descriptionNow, the message center is not activatable by default, so that the direct reply is not working: key-events are not sent to Android correctly. We need to make the message center activatable and active before user uses the direct reply. This change is the cause of this regression: https://codereview.chromium.org/2897553002/
,
Aug 10 2017
,
Aug 10 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
I confirmed it's working on 62.0.3174.0 canary
,
Aug 10 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0479d3a76a8fe5455277966346ff6f099ed599a0 commit 0479d3a76a8fe5455277966346ff6f099ed599a0 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Aug 10 17:19:09 2017 Activate Widget and Focus SurfaceWindow when DirectInput is used With the recent change (crrev.com/2897553002), the message center is not activatable by default, so that the direct reply was not working: key-events were not sent to Android correctly. This patch makes the message center activatable and active before user uses the direct reply. TBR=yoshiki@chromium.org (cherry picked from commit 5cecf6b16b816e0dea3f61bcbee9ed0b7fc81111) Bug: 753287 Change-Id: Ib34db94e03e78f136a52ae2850551bf968b9c9e4 Reviewed-on: https://chromium-review.googlesource.com/604644 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492721} Reviewed-on: https://chromium-review.googlesource.com/610640 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#434} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_content_view.cc [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_content_view.h [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_surface.h [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_surface_impl.cc [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/arc/notification/arc_notification_surface_impl.h [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/message_center/views/toast_contents_view.cc [modify] https://crrev.com/0479d3a76a8fe5455277966346ff6f099ed599a0/ui/message_center/views/toast_contents_view.h
,
Aug 10 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 8 2017