New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753284 link

Starred by 1 user
Status: Fixed
Owner:
█ kenobi@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Container bucket crashes if host dir is not mounted.

Project Member Reported by kenobi@chromium.org, Aug 8 2017 
To repro:

mkdir /usr/local/autotest/container/host
sudo python site_utils/lxc/lxc_functional_test.py

The functional test will crash during container bucket setup.

It's possible this could have an impact on autotest servers.  If the shared host dir (/usr/local/autotest/containers/host) is not cleaned up properly, i.e. it is umounted but not deleted, subsequent container bucket setup will fail until the host dir is manually removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3778cdbffba78fa2c016d786df714e1dcd13bf67

commit 3778cdbffba78fa2c016d786df714e1dcd13bf67
Author: Ben Kwa <kenobi@google.com>
Date: Wed Aug 09 18:48:03 2017

[autotest] Fix a crash in host dir creation.

Fix a crash that occurs if the container bucket encounters a host dir that is
not mounted.  This can occur, for example, if a server is rebooted - the host
dir will still exist, but it will no longer be mounted.

BUG= chromium:753284 
TEST=sudo python container_bucket_unittest.py
TEST=sudo python lxc_functional_test.py

Change-Id: Ie42d6634a6ab3fd5db335cc98685ed86f2f9908a
Reviewed-on: https://chromium-review.googlesource.com/604773
Commit-Ready: Ben Kwa <kenobi@chromium.org>
Tested-by: Ben Kwa <kenobi@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/3778cdbffba78fa2c016d786df714e1dcd13bf67/site_utils/lxc/container_bucket.py
[modify] https://crrev.com/3778cdbffba78fa2c016d786df714e1dcd13bf67/site_utils/lxc/container_bucket_unittest.py

Comment 2 by kenobi@chromium.org, Aug 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment