New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753278 link

Starred by 1 user
Status: Fixed
Owner:
█ emim@google.com
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove TODOs about spec discussion for no active worker in service_worker_dispatcher_host.cc

Project Member Reported by falken@chromium.org, Aug 8 2017 
There are some TODOs like this in service_worker_dispatcher_host.cc:

  // The spec discussion consensus is to reject if there is no active worker:
  // https://github.com/w3c/ServiceWorker/issues/920#issuecomment-262212670
  // TODO(falken): Remove this comment when the spec is updated.

We can remove these comments since the spec was already updated.

This is a simpler first patch than removing the flag :)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b790018bc4f844df911716f70ecf0907d38576ad

commit b790018bc4f844df911716f70ecf0907d38576ad
Author: Emi Morikawa <emim@google.com>
Date: Wed Aug 09 06:10:27 2017

Remove outdated TODOs in ServiceWorkerDispatcherHost.

The spec has been updated as expected, so the comment is no longer needed.

Bug:  753278 
Change-Id: Iae7409e064e5abc0b98ce80630d134ad819eb76f
Reviewed-on: https://chromium-review.googlesource.com/606849
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Emi Morikawa <emim@google.com>
Cr-Commit-Position: refs/heads/master@{#492848}
[modify] https://crrev.com/b790018bc4f844df911716f70ecf0907d38576ad/content/browser/service_worker/service_worker_dispatcher_host.cc

Comment 2 by emim@google.com, Aug 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment