New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753273 link

Starred by 1 user
Status: Fixed
Owner:
█ owenlin@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
█ w...@chromium.org
sande...@chromium.org
█ hubbe@chromium.org
liber...@chromium.org
tfiga@chromium.org
dalecur...@chromium.org
█ jbau...@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Remove display functionality in vda_unittest

Project Member Reported by wuchengli@chromium.org, Aug 8 2017 
This is the first step of removing rendering in vda_unittest.
- Rendering is the reason that VTVDA and AVDA do not have vda_unittest support. 
- The rendering code in the test is different from chrome. It's easily broken by other graphics or media CLs. 
- When the rendering in vda_unittest is wrong (e.g. having green lines at the bottom due to alignment), it doesn't mean chrome rendering has problems. When rendering in chrome has a bug, vda_unittest may not show it.

vda_unittest is using rendering to (1) display on the screen and (2) draw thumbnails for the thumbnail test. This bug is to track removing display functionality from vda_unittest.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27c7f330af36d90d1c9f8b504a02dd20f8a1a006

commit 27c7f330af36d90d1c9f8b504a02dd20f8a1a006
Author: Owen Lin <owenlin@google.com>
Date: Mon Sep 18 04:51:13 2017

rendering_helper: Use Offscreen GL surface.

The goal is to make vda_unittest less dependent on the platforms. 
As the first step, we disable the rendering from vda_unittest. After
this change, it no longer displays the frames on the screen.

BUG= 753273 
TEST=Run test on a CrOS device.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6e3319dd329996c879d251f49bdfcc0fe84b542f
Reviewed-on: https://chromium-review.googlesource.com/654459
Commit-Queue: Owen Lin <owenlin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502532}
[modify] https://crrev.com/27c7f330af36d90d1c9f8b504a02dd20f8a1a006/media/gpu/rendering_helper.cc
[modify] https://crrev.com/27c7f330af36d90d1c9f8b504a02dd20f8a1a006/media/gpu/rendering_helper.h
[modify] https://crrev.com/27c7f330af36d90d1c9f8b504a02dd20f8a1a006/media/gpu/video_decode_accelerator_unittest.cc

Comment 2 by wuchengli@chromium.org, Sep 25 2017 

The patch in #1 was picked up in 9964.0.0 on Sep 22.

Comment 3 by owenlin@chromium.org, Jan 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment