New issue
Advanced search Search tips

Issue 753271 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Reinstate active flag for iterators

Project Member Reported by annevank...@gmail.com, Aug 8 2017

Issue description

Status: Available (was: Unconfirmed)
Owner: rakina@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d64c9120f3983c14be77e2de1404e89a971bc3ad

commit d64c9120f3983c14be77e2de1404e89a971bc3ad
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Fri Nov 10 06:36:33 2017

Add active flag check to node filter steps

The spec for node filtering steps was recently updated, adding active
flags to avoid recursive invocations.

This change added the active flag property and the active flag checks in
the node filtering steps.

Spec:
https://dom.spec.whatwg.org/#concept-traversal-active

Bug:  753271 
Change-Id: I7cdd57f86401bd6ea9a8012f28b47afa8a60a65b
Reviewed-on: https://chromium-review.googlesource.com/760238
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515485}
[delete] https://crrev.com/7d5912ce4bb64fdffe673abc894af0b91478a33a/third_party/WebKit/LayoutTests/external/wpt/dom/traversal/NodeIterator-expected.txt
[delete] https://crrev.com/7d5912ce4bb64fdffe673abc894af0b91478a33a/third_party/WebKit/LayoutTests/external/wpt/dom/traversal/TreeWalker-expected.txt
[modify] https://crrev.com/d64c9120f3983c14be77e2de1404e89a971bc3ad/third_party/WebKit/LayoutTests/traversal/moz-bug559526-expected.txt
[modify] https://crrev.com/d64c9120f3983c14be77e2de1404e89a971bc3ad/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp
[modify] https://crrev.com/d64c9120f3983c14be77e2de1404e89a971bc3ad/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h

Comment 4 by rakina@chromium.org, Nov 10 2017

Status: Fixed (was: Started)

Sign in to add a comment