UMA to understand the cost of sync document.cookie getter calls |
|||
Issue descriptionBug reports like https://bugs.chromium.org/p/chromium/issues/detail?id=729800&desc=2#c4 indicate a surprising amount of jank can result from invoking the sync IPC for getting the value of a cookie (defined here: https://cs.chromium.org/chromium/src/content/common/render_frame_message_filter.mojom?rcl=d3fd77dfa8c23044392dd016d6d5aeb0165f1c78&l=18) Firefox made their IPC async in https://bugzilla.mozilla.org/show_bug.cgi?id=1331680, and we should probably consider doing the same. UMA would be useful to understand how important this issue is in practice. Can we get something in the next milestone?
,
Aug 8 2017
Fairly easy to do. I think we probably want some numbers on sizing as well to measure how much bigger this will make the memory footprint in the renderer.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47dfeb31fc658a0c824dc86af451c117b220ca5b commit 47dfeb31fc658a0c824dc86af451c117b220ca5b Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Aug 09 08:07:15 2017 Add UMA to measure time to serve the sync IPC for retrieving cookies Bug: 753247 Change-Id: Idb969f0c5b15c4bd0ae85a5e8fe595ec4f5eefda Reviewed-on: https://chromium-review.googlesource.com/604645 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#492890} [modify] https://crrev.com/47dfeb31fc658a0c824dc86af451c117b220ca5b/third_party/WebKit/Source/core/loader/CookieJar.cpp [modify] https://crrev.com/47dfeb31fc658a0c824dc86af451c117b220ca5b/tools/metrics/histograms/histograms.xml
,
Aug 11 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kenjibaheux@chromium.org
, Aug 8 2017