New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753244 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 751970



Sign in to add a comment

Mac: Creating a new tab sets up tracking areas on the page info button 21 times. Switching tabs: 18 times.

Project Member Reported by tapted@chromium.org, Aug 8 2017

Issue description

Chrome Version       : 62.0.3175.0
OS Version: OS X 10.12.6

Log in 

- (void)updateMouseTrackingAndToolTipsInRect:(NSRect)cellFrame
                                      ofView:
                                          (AutocompleteTextField*)controlView {

or 

- [AutocompleteTextFieldCell clearTrackingArea]


Switch tabs, and observe. Such logs. Wow.
 
Cc: spqc...@chromium.org
I suspect this is a contributor to  Issue 746597 . I am investigating as part of  Issue 752900 .
Calls are coming from

-[TabStripController clickNewTabButton:] + 372 ... Browser::ActiveTabChanged()
 -> Browser::UpdateToolbar
  -> -[BrowserWindowController updateToolbarWithContents:]
    -> LocationBarViewMac::Update(WebContents*)
      -> LocationBarViewMac::UpdateManagePasswordsIconAndBubble() -> LocationBarViewMac::OnDecorationsChanged() -> -[AutocompleteTextField updateMouseTracking]
      -> LocationBarViewMac::UpdateSaveCreditCardIcon() -> LocationBarViewMac::OnDecorationsChanged() -> -[AutocompleteTextField updateMouseTracking]
    -> -[ToolbarController updateToolbarWithContents:] -> LocationBarViewMac::Update(content::WebContents const*)
      -> OmniboxViewMac::OnTabChanged(content::WebContents const*) + 110 ... OmniboxEditModel::OnChanged() ... -> LocationBarViewMac::UpdateLocationIcon() -> LocationBarViewMac::Layout()
        -> -[AutocompleteTextFieldCell clearDecorations]
        -> LocationBarViewMac::OnDecorationsChanged() -> -[AutocompleteTextField updateMouseTracking]
        -> above two repeat
      -> LocationBarViewMac::OnChanged() -> LocationBarViewMac::UpdateLocationIcon() -> LocationBarViewMac::Layout()
        -> -[AutocompleteTextFieldCell clearDecorations]
        -> LocationBarViewMac::OnDecorationsChanged() -> -[AutocompleteTextField updateMouseTracking]
    -> -[AutocompleteTextField updateMouseTracking] + 302
 -> chrome::BrowserCommandController::TabStateChanged() + 21 -> UpdateCommandsForTabState() -> BrowserWindowCocoa::SetStarredState -> LocationBarViewMac::SetStarred(bool) -> LocationBarViewMac::OnDecorationsChanged() -> updateMouseTracking
content::RenderFrameHostImpl::OnDidStartProvisionalLoad -> BookmarkTabHelper::DidStartNavigation -> BrowserWindowCocoa::SetStarredState -> (as above)
content::RenderFrameHostImpl::OnDidCommitProvisionalLoad -> NotifyNavigationEntryCommitted
 -> DidCommitProvisionalLoad -> VisibleSecurityStateChanged -> Browser::UpdateToolbar(bool)
  (9 calls above from the UpdateToolbar invoked via ActiveTabChanged repeat)
 -> NotifyNavigationStateChanged -> Browser::ScheduleUIUpdate -> Browser::UpdateToolbar(bool)
  (more repeats, but only 5 this time: UpdateManagePasswordsIconAndBubble, UpdateSaveCreditCardIcon, UpdateLocationIcon,  -[ToolbarController updateToolbarWithContents:])
 -> content::NavigatorImpl::DidNavigate -> content::WebContentsImpl::DidFinishNavigation -> LocationBarViewMac::UpdateManagePasswordsIconAndBubble() -> LocationBarViewMac::OnDecorationsChanged()
Components: UI>Browser>Omnibox
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)
Assignign to tapted, since he says he's investigating in c#1.
Blockedon: 751970
Cc: tapted@chromium.org
Owner: ----
Status: Available (was: Assigned)
I won't be looking at this any time soon. views doesn't have tracking areas, so this could potentially just go away. Doesn't seem to do anything bad by itself (apart from  Issue 746597 , assuming they're related).
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 9

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-CocoaBrowser
Status: Available (was: Untriaged)

Sign in to add a comment