New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753240 link

Starred by 1 user
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ mgiuca@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug-Regression

Blocking:
issue 740783



Sign in to add a comment

DesktopPWAWindowing: Omnibox navigation should not open app

Project Member Reported by mgiuca@chromium.org, Aug 8 2017 
Chrome Version: 62 (post r492505)
OS: Windows, Linux, CrOS

What steps will reproduce the problem?
(1) Run with --enable-features=DesktopPWAWindowing
(2) Install an app (e.g., https://killer-marmot.appspot.com/web, Add to Desktop, Open in Window)
(3) Type/paste app URL in Omnibox (https://killer-marmot.appspot.com/web).

What is the expected result?
Navigates to app in a tab.

What happens instead?
Opens the app window.

(Gio: I know you're working on a fix for this: https://chromium-review.googlesource.com/c/593447, but I wanted to capture this as a separate issue for tracking purposes.)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394

commit fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Aug 09 04:08:05 2017

desktop-pwas: Only open app for link navigations.

Only PAGE_TRANSITION_LINK will open a new App window. The remaining
types of PageTransitions[1] won't.

[1] https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h

Bug: 740783,  753240 ,  753239 
Change-Id: I4230137cdbaf9b0f8b909c5d8cf8457e03884b07
Reviewed-on: https://chromium-review.googlesource.com/593447
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492819}
[modify] https://crrev.com/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394/chrome/browser/apps/app_url_redirector.cc
[modify] https://crrev.com/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc

Comment 2 by ortuno@chromium.org, Aug 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment