DesktopPWAWindowing: Refresh should not open app |
||
Issue descriptionChrome Version: 62 (post r492505) OS: Windows, Linux, CrOS What steps will reproduce the problem? (1) Run with --enable-features=DesktopPWAWindowing (2) Navigate to an app site (e.g., https://killer-marmot.appspot.com/web). (3) Install the app (Add to Desktop, Open in Window) (4) Refresh the open tab. What is the expected result? Refreshes the page in a tab. What happens instead? Opens the app window.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394 commit fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Wed Aug 09 04:08:05 2017 desktop-pwas: Only open app for link navigations. Only PAGE_TRANSITION_LINK will open a new App window. The remaining types of PageTransitions[1] won't. [1] https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h Bug: 740783, 753240 , 753239 Change-Id: I4230137cdbaf9b0f8b909c5d8cf8457e03884b07 Reviewed-on: https://chromium-review.googlesource.com/593447 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#492819} [modify] https://crrev.com/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394/chrome/browser/apps/app_url_redirector.cc [modify] https://crrev.com/fa8f9f6c31328ec15f0a34cff57e3dbbfc7f2394/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc
,
Aug 9 2017
This is currently implemented, but we are missing tests. So, leaving this opened.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/460cc3e4fded826996636cbeb0769dd4c1060d16 commit 460cc3e4fded826996636cbeb0769dd4c1060d16 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Aug 29 07:59:22 2017 desktop-pwas: Add tests for all transition types Adds tests to make sure all transition types result in the correct outcome. Bug: 740783, 753239 Change-Id: I1000dcb08ace494e6fa4d962b934cb7b07f0f507 Reviewed-on: https://chromium-review.googlesource.com/618202 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#498044} [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/content/public/test/test_frame_navigation_observer.cc [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/content/public/test/test_frame_navigation_observer.h [modify] https://crrev.com/460cc3e4fded826996636cbeb0769dd4c1060d16/ui/base/page_transition_types.h
,
Aug 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mgiuca@chromium.org
, Aug 8 2017