New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753230 link

Starred by 2 users
Status: Fixed
Owner:
█ emim@google.com
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove ServiceWorkerNavigationPreload flags

Project Member Reported by falken@chromium.org, Aug 8 2017 
The feature shipped in M59.

Things to remove include:
1) features::kServiceWorkerNavigationPreload from chrome/browser directory
2) ServiceWorkerNavigationPreload from third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
3) "service-worker-navigation-preload*" related configurations in third_party/WebKit/LayoutTests/VirtualTestSuites and the related expectation files in  third_party/WebKit/LayoutTests/virtual

Here is a brief explanation of what each was doing:
1) is used for the command-line flag or chrome://flags (see 
2) is used to enable/disable the feature in Blink (see https://www.chromium.org/blink/runtime-enabled-features)
3) is used to flip the feature is on or off when running tests (see https://chromium.googlesource.com/chromium/src/+/lkcr/docs/testing/layout_tests.md)

Now the feature should always be enabled so we don't need the flag or any of these.

Comment 1 by falken@chromium.org, Aug 8 2017 

Also the entry in testing/variations/fieldtrial_testing_config.json and mentions of RuntimeEnabled=ServiceWorkerNavigationPreload in *.idl files.

Maybe be easier to do this in stages: try removing 1) first and then 3) and then 2).
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/082e3909a15048911e2ef93384ee8c56bc7ea05f

commit 082e3909a15048911e2ef93384ee8c56bc7ea05f
Author: Emi Morikawa <emim@google.com>
Date: Tue Aug 15 00:03:00 2017

Remove ServiceWorkerNavigationPreload flags

The spec has been updated as expected, so the flags is no longer needed.

Bug:  753230 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I512b16371de5cc7e487eab767b8111bd81a21db1
Reviewed-on: https://chromium-review.googlesource.com/609058
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Emi Morikawa <emim@google.com>
Cr-Commit-Position: refs/heads/master@{#494256}
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/chrome/browser/about_flags.cc
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/content/child/runtime_features.cc
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/content/public/common/content_features.cc
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/content/public/common/content_features.h
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/README.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/README.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/README.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/navigation-preload-origin-trial-methods-expected.txt
[delete] https://crrev.com/6a429a5fd6a7c25ca3e9eb218cadc904ceed62ee/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.idl
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/082e3909a15048911e2ef93384ee8c56bc7ea05f/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp

Comment 3 by emim@google.com, Aug 16 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a30dd002e7618e46616e91cdbd79dce11d196043

commit a30dd002e7618e46616e91cdbd79dce11d196043
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jul 24 07:31:58 2018

service worker: Remove unused strings for navigation preload flag.

The ServiceWorkerNavigationPreload feature flag was removed in r494256.

Bug:  753230 
Change-Id: Ie2fe09c477dbffe1bc19cc050f1e6f413b1a8358
Reviewed-on: https://chromium-review.googlesource.com/1148021
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577447}
[modify] https://crrev.com/a30dd002e7618e46616e91cdbd79dce11d196043/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a30dd002e7618e46616e91cdbd79dce11d196043/chrome/browser/flag_descriptions.h
►

Sign in to add a comment