New issue
Advanced search Search tips

Issue 753229 link

Starred by 1 user
Status: Assigned
Owner:
pwang@chromium.org
Cc:
ihf@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

graphics_WebGLPerformance multiplies an arbitrary number of results and compares that

Project Member Reported by marc...@chromium.org, Aug 8 2017 
Context is this bug:

https://bugs.chromium.org/p/chromium/issues/detail?id=751883

a Chrome CL enabled 4 extra tests, which changed the geometric mean, which looked like a regression but wasn't.

We should fix the test, probably to do two things:
- the rgb float tests are incorrect, and they violate GL spec. So we should remove them
- we should ensure that the number of values used to compute the mean is always the same
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7f8d2558d23068c7acac7e4bc6e856b11de6176d

commit 7f8d2558d23068c7acac7e4bc6e856b11de6176d
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Wed Aug 09 18:48:02 2017

WebGL_Performance: waive certain tests

1) Add ability to waive certain tests.
2) Waive rgb float tests as it is not in spec.
3) Check if there are any failed tests in graphics_WebGLPerformance

BUG=chromium:753229
TEST=test_that

Change-Id: I37aeb2a86b4cc4115b410f533379ffd3435fd810
Reviewed-on: https://chromium-review.googlesource.com/607178
Commit-Ready: Po-Hsien Wang <pwang@chromium.org>
Tested-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[add] https://crrev.com/7f8d2558d23068c7acac7e4bc6e856b11de6176d/client/deps/webgl_perf/files/0003-Waive-certain-tests.patch
[modify] https://crrev.com/7f8d2558d23068c7acac7e4bc6e856b11de6176d/client/deps/webgl_perf/webgl_perf.py
[modify] https://crrev.com/7f8d2558d23068c7acac7e4bc6e856b11de6176d/client/site_tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6046c0716fe42d263e6f2d84a4df8583e17a6398

commit 6046c0716fe42d263e6f2d84a4df8583e17a6398
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Thu Sep 21 08:08:07 2017

graphics_WebGL*: move calculation logic from webgl_perf

Refactoring webgl_perf to let the calculation is done
in graphics_WebGLPerformance.

1) Move geo_mean calculation to graphics_WebGLPerformance.
2) Move waived_list check to graphics_WebGLPerformance.

BUG=chromium:753229
TEST=test_that dut graphics_WebGLPerformance

Change-Id: Iddee465b5d47523bd3af4c8c5fec63d2b17fe4de
Reviewed-on: https://chromium-review.googlesource.com/673745
Commit-Ready: Po-Hsien Wang <pwang@chromium.org>
Tested-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/6046c0716fe42d263e6f2d84a4df8583e17a6398/client/site_tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py
[delete] https://crrev.com/abaf065e9e0b046a772997268c2cfa9d63cd1ac0/client/deps/webgl_perf/files/0003-Waive-certain-tests.patch
[add] https://crrev.com/6046c0716fe42d263e6f2d84a4df8583e17a6398/client/deps/webgl_perf/files/0002-Report-tests-url-name.patch
[modify] https://crrev.com/6046c0716fe42d263e6f2d84a4df8583e17a6398/client/deps/webgl_perf/webgl_perf.py
[delete] https://crrev.com/abaf065e9e0b046a772997268c2cfa9d63cd1ac0/client/deps/webgl_perf/files/0002-Always-increment-numberOfResults.patch

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment