New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753228 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
OOO Dec 22 - Jan 8
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Flaky unit tests: AudioRendererSinkCacheTest.MultithreadedAccess

Project Member Reported by shimazu@chromium.org, Aug 8 2017

Issue description

Looking at the flakiness dashboard, the test seems flaky on Linux TSan Tests. 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=AudioRendererSinkCacheTest.MultithreadedAccess%0A

Could you triage and fix this if possible?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26252c125ee74354bb9ac16af07bb7a0ee067091

commit 26252c125ee74354bb9ac16af07bb7a0ee067091
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Aug 08 04:30:22 2017

Disabled flaky AudioRendererSinkCacheTest.MultithreadedAccess on Linux

AudioRendererSinkCacheTest.MultithreadedAccess is flaky on Linux TSan bots.
This patch disables the test on OS_LINUX.

TBR=olka@chromium.org,miu@chromium.org

Bug:  753228 
Change-Id: I619ee7ab1ff3a285ca158dabdeb8c91d06c3e137
Reviewed-on: https://chromium-review.googlesource.com/604816
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492532}
[modify] https://crrev.com/26252c125ee74354bb9ac16af07bb7a0ee067091/content/renderer/media/audio_renderer_sink_cache_unittest.cc

Comment 2 by olka@chromium.org, Aug 10 2017

Labels: -Pri-2 Pri-1
See also  issue 753228 

May be related to may be retated to https://chromium-review.googlesource.com/c/549520


Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a9b8511c51001a188fbce0699541b1662e1c5e8

commit 2a9b8511c51001a188fbce0699541b1662e1c5e8
Author: Olga Sharonova <olka@chromium.org>
Date: Mon Aug 28 13:03:53 2017

Revert "Disabled flaky AudioRendererSinkCacheTest.MultithreadedAccess on Linux"

This reverts commit 26252c125ee74354bb9ac16af07bb7a0ee067091.

Reason for revert:
BUG= 753228 
No logs in the bug/on bots; failed to reproduce it locally with a tsan build and on CQ tsan (https://chromium-review.googlesource.com/c/chromium/src/+/625776).
Re-enabling to collect the logs.

Original change's description:
> Disabled flaky AudioRendererSinkCacheTest.MultithreadedAccess on Linux
> 
> AudioRendererSinkCacheTest.MultithreadedAccess is flaky on Linux TSan bots.
> This patch disables the test on OS_LINUX.
> 
> TBR=olka@chromium.org,miu@chromium.org
> 
> Bug:  753228 
> Change-Id: I619ee7ab1ff3a285ca158dabdeb8c91d06c3e137
> Reviewed-on: https://chromium-review.googlesource.com/604816
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492532}

TBR=miu@chromium.org,shimazu@chromium.org,olka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  753228 
Change-Id: I163a3f82f035ba3ae70c4148256f9e7716781568
Reviewed-on: https://chromium-review.googlesource.com/627357
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497743}
[modify] https://crrev.com/2a9b8511c51001a188fbce0699541b1662e1c5e8/content/renderer/media/audio_renderer_sink_cache_unittest.cc

Comment 4 by olka@chromium.org, Aug 29 2017

Status: WontFix (was: Assigned)
the last 30+ TSan builds with the re-enabled test has been green (https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests?numbuilds=200). Closing the bug.

Sign in to add a comment