New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753195 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tether user pref toggle in quick settings is awkward when Bluetooth is disabled

Project Member Reported by hansberry@chromium.org, Aug 8 2017

Issue description

When BT is disabled, the toggle for Tether in quick settings behaves awkwardly: it can be toggled to enabled, but then immediately flips back to disabled. It likely should be greyed out.
 
According to the mocks, the toggle should not be present at all in this case.
Owner: lesliewatkins@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16a4499b47e294d28bd8533c65b4952d875e4d43

commit 16a4499b47e294d28bd8533c65b4952d875e4d43
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Thu Aug 10 02:07:38 2017

Add the ability to hide the toggle in SectionHeaderRowView.

The toggle is hidden for the Mobile Data section in the case when
Tether is available but Bluetooth is disabled.

Bug:  753195 , 672263
Change-Id: I6341e6339d6b090008a774a470534668744d8f58
Reviewed-on: https://chromium-review.googlesource.com/609440
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493225}
[modify] https://crrev.com/16a4499b47e294d28bd8533c65b4952d875e4d43/ash/system/network/network_icon.cc
[modify] https://crrev.com/16a4499b47e294d28bd8533c65b4952d875e4d43/ash/system/network/network_list.cc
[modify] https://crrev.com/16a4499b47e294d28bd8533c65b4952d875e4d43/ash/system/network/network_list.h

Labels: Merge-Request-61

Comment 6 by ketakid@google.com, Aug 10 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76fd3a58c936133c01980bbf6dc97011ed8f1d39

commit 76fd3a58c936133c01980bbf6dc97011ed8f1d39
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 10 18:05:27 2017

Add the ability to hide the toggle in SectionHeaderRowView.

The toggle is hidden for the Mobile Data section in the case when
Tether is available but Bluetooth is disabled.

TBR=lesliewatkins@chromium.org

(cherry picked from commit 16a4499b47e294d28bd8533c65b4952d875e4d43)

Bug:  753195 , 672263
Change-Id: I6341e6339d6b090008a774a470534668744d8f58
Reviewed-on: https://chromium-review.googlesource.com/609440
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493225}
Reviewed-on: https://chromium-review.googlesource.com/610881
Cr-Commit-Position: refs/branch-heads/3163@{#437}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/76fd3a58c936133c01980bbf6dc97011ed8f1d39/ash/system/network/network_icon.cc
[modify] https://crrev.com/76fd3a58c936133c01980bbf6dc97011ed8f1d39/ash/system/network/network_list.cc
[modify] https://crrev.com/76fd3a58c936133c01980bbf6dc97011ed8f1d39/ash/system/network/network_list.h

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment