Settings>Change Picture page is blank after you capture a photo and delete it. |
|||||||||
Issue descriptionChrome OS version: 62.0.3176.0, dev build Platform version: 9817.0.0, dev channel caroline device M-62 build 1. Goto Settings>People>Change Picture 2. Click on 'Choose a file' option> here do not select any file, just cancel this window. 3. Observe that there is no picture on the L.H.S. Previously existed sign in picture is vanished. 4. Observe that the sign in picture on shelf is a previous one. --> scenario 1. 5. Go back to previous screen and once again move to 'Change Picture' page. Now you can see the actual sign in picture. 6. Now select 'Take a photo' option> capture a photo and delete it. 7. Go back to previous screen. Here a default profile pic is shown under 'Settings>People'. Once again move to 'Change Picture' page. 8. Observe that there is no picture on the L.H.S. If you repeat steps 7-8, the result seen is the same. 9. Observe that the sign in picture on shelf is a default one. ---->scenario 2. 10. Close the window. Once again navigate to Settings>Change picture. 11. Observe that now a default picture is shown on the L.H.S. Expected result: 1. I believe at the end of scenario 1, previously existed profile picture should be shown on the L.H.S (Change Picture page). 2. At the end of scenario 2, a default picture should be shown on the L.H.S (Change Picture page). 3. All the pictures must be synchronized--->in Change picture page, Settings>People page and Sign in picture on shelf. Please refer the video for more clarity.
,
Aug 9 2017
,
Aug 14 2017
Over to reveman@ who has been landing changes here.
,
Aug 15 2017
,
Aug 15 2017
Thanks for the detailed report. Not sure what's causing this but I'll make sure this gets fixed asap.
,
Aug 18 2017
,
Aug 21 2017
Uploaded a fix for the photo discard button not working correctly: https://chromium-review.googlesource.com/c/622968 No preview image showing after canceling a file open operation might be the intended behavior so I haven't done anything about that.
,
Aug 21 2017
issue 757376 may be related.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6808e9e01d1947b358ce3ddd103c73912fbdabd commit e6808e9e01d1947b358ce3ddd103c73912fbdabd Author: David Reveman <reveman@chromium.org> Date: Tue Aug 22 01:16:34 2017 Change Picture: Revert to profile picture when discarding image Switch to default profile picture to ensure that photo is discarded properly. Prior to this change the photo would not actually be discarded unless another user icon was selected after pressing the discard button. Bug: 753191 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibbf8220232189720352798a07a8c45ab5d4db49c Reviewed-on: https://chromium-review.googlesource.com/622968 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#496162} [modify] https://crrev.com/e6808e9e01d1947b358ce3ddd103c73912fbdabd/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/e6808e9e01d1947b358ce3ddd103c73912fbdabd/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/e6808e9e01d1947b358ce3ddd103c73912fbdabd/chrome/test/data/webui/settings/people_page_change_picture_test.js [modify] https://crrev.com/e6808e9e01d1947b358ce3ddd103c73912fbdabd/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f51fac2dc5dd8c709b80b3fbe2b274b7cc2a89c4 commit f51fac2dc5dd8c709b80b3fbe2b274b7cc2a89c4 Author: David Reveman <reveman@chromium.org> Date: Fri Aug 25 08:10:55 2017 Change Picture: Revert to profile picture when discarding image Switch to default profile picture to ensure that photo is discarded properly. Prior to this change the photo would not actually be discarded unless another user icon was selected after pressing the discard button. TBR=reveman@chromium.org (cherry picked from commit e6808e9e01d1947b358ce3ddd103c73912fbdabd) Bug: 753191 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibbf8220232189720352798a07a8c45ab5d4db49c Reviewed-on: https://chromium-review.googlesource.com/622968 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496162} Reviewed-on: https://chromium-review.googlesource.com/634707 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#881} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/f51fac2dc5dd8c709b80b3fbe2b274b7cc2a89c4/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/f51fac2dc5dd8c709b80b3fbe2b274b7cc2a89c4/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/f51fac2dc5dd8c709b80b3fbe2b274b7cc2a89c4/chrome/test/data/webui/settings/people_page_change_picture_test.js [modify] https://crrev.com/f51fac2dc5dd8c709b80b3fbe2b274b7cc2a89c4/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Sep 8 2017
,
Nov 8 2017
Verified on M64 dev build (10109.0.0, 64.0.3261.0). |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mkarkada@chromium.org
, Aug 8 2017