Harmony - screen share picker (DesktopMediaPickerViews) |
|||||||||
Issue descriptionDidn't find an existing bug or mocks for this dialog.
,
Aug 9 2017
Alan, it looks like there used to be a mock at: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20screenshare.png%3Fz=width But that link doesn't resolve anymore. Assigned to you to provide a current mock for this.
,
Aug 9 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10d0c56779893f562c679cc748ff35bc29f5e38e commit 10d0c56779893f562c679cc748ff35bc29f5e38e Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Aug 10 01:30:36 2017 Add DialogBrowserTest for DesktopMediaPickerViews. Bug: 753187 Change-Id: I0f3c0354ae513c85279b31562a33805c702876f1 Reviewed-on: https://chromium-review.googlesource.com/604939 Reviewed-by: Qiang Chen <qiangchen@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#493214} [modify] https://crrev.com/10d0c56779893f562c679cc748ff35bc29f5e38e/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [add] https://crrev.com/10d0c56779893f562c679cc748ff35bc29f5e38e/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_browsertest.cc [modify] https://crrev.com/10d0c56779893f562c679cc748ff35bc29f5e38e/chrome/test/BUILD.gn
,
Aug 17 2017
Hey Bret, I have a few questions about this one so I figured we'd talk about it in person next week Questions: Is this a tableview? Entire screen thumbnail is way large Keyboard tabbing doesn’t work for navigating thru tabs Body text could be improved Incorrect positioning for modal dialog Remove the close-x Application window is too technical. What about tabs? Icons are apps (chrome) not site (favicon) What determines the ordering? Any usage metrics? Notes can be found here: https://docs.google.com/presentation/d/1efIBdWozcOXv1hEaIxdcdf4A1-8P8HQu7bRpEokLisI/edit?userstoinvite=crivero@google.com&ts=5991f0cf#slide=id.g24e42e57cc_0_18
,
Aug 21 2017
Just spoke with Bret on this - it's unclear if this dialog should be prioritized as a Primary dialog. If it is and once an engineer is dedicated to this UI, we can address the questions above and work towards a spec. Preliminary mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview/18-Screenshare#%2FP%20-%20screenshare.png%3Fz=width Notes can be found here: https://docs.google.com/presentation/d/1efIBdWozcOXv1hEaIxdcdf4A1-8P8HQu7bRpEokLisI/edit?userstoinvite=crivero@google.com&ts=5991f0cf#slide=id.g24e42e57cc_0_18
,
Aug 23 2017
I don't know how we decided what's "primary" vs. "misc.". I don't feel strongly about how this is grouped. However, in either case, we'll want this to ship in the first Harmony release, so even if not dedicating an engineer now, we'll need to make sure this is implementable within the next few months. The mock in comment 6 looks like enough to work from for now when we do launch into this. ->rpop to clarify grouping/priority logic. If we decide this is "misc." we can lower to P2, otherwise this needs an owner.
,
Sep 5 2017
,
Sep 5 2017
,
Sep 20 2017
This is only impacting Googlers only mostly, and a complicated change. Moving to P3 (for Phase 2)
,
Sep 29 2017
The NextAction date has arrived: 2017-09-29
,
Jan 10
Archiving P3s older than 1 year with no owner or component. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pkasting@chromium.org
, Aug 9 2017