New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753173 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Consolidate Page Info and Site Settings Strings

Project Member Reported by patricia...@chromium.org, Aug 8 2017

Issue description

Consolidate common strings in Page Info and Site Settings. In particular, Site Details has strings used in the drop-down menus to change a permission for a specific site, such as 'Allow', 'Block', etc. However, there are probably other strings that also should be consolidated, such as all the names of the permissions, e.g. 'Camera', 'Location', which are currently duplicated in page_info_strings.grdp and settings_strings.grdp.

These strings will be used in both places, so de-duplicate the ones that are used to mean the same thing and put them somewhere more generic where it makes sense for both Site Settings and Page Info to be using them.

Some links to the relevant strings:

Names of permissions

Site Settings: https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?rcl=48052e3a9007a8068978b416110f94de1b49cb8a&l=2037
Page Info: https://cs.chromium.org/chromium/src/components/page_info_strings.grdp?rcl=48052e3a9007a8068978b416110f94de1b49cb8a&l=179

Select menu options

Site Settings: https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?rcl=48052e3a9007a8068978b416110f94de1b49cb8a&l=2224
Page Info: https://cs.chromium.org/chromium/src/components/page_info_strings.grdp?rcl=48052e3a9007a8068978b416110f94de1b49cb8a&l=218
 
:-D

I've moved just about everything named PAGE_INFO into page_info_strings.grdp, and this sounds like a good next step.

If the only affected strings are permissions, how about permissions.grdp?
Sounds good to me! I'm pretty sure they will only be permission-related strings. FYI, I won't be able to work on this probably until September sometime.

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment