New issue
Advanced search Search tips

Issue 753167 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Splitscreen window grid should move if a window can be snapped.

Project Member Reported by sammiequon@chromium.org, Aug 8 2017

Issue description

Right now splitscreen window grid only moves to the correct location after a window has been snapped.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674

commit fbd6d1ac1e2516ef48761afd8c6288fd5c86a674
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Aug 15 17:50:13 2017

tablet: Splitscreen window grid should move if a window can be snapped.

If there is currently no snapped window, and we drag an item which can be snapped when dropped, the window grid should shift to the opposite side, so that the phantom window does not cover any of the other window.

Test: ash_unittests "WindowSelectorTest.WindowGridSizeWhileDraggingWithSplitView"
Bug:  753167 
Change-Id: I695e71dbd0e35d0c0ff68f14fbad73dee57ceaa2
Reviewed-on: https://chromium-review.googlesource.com/604400
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494438}
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/overview_window_drag_controller.h
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/window_grid.h
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/window_selector.h
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/fbd6d1ac1e2516ef48761afd8c6288fd5c86a674/ash/wm/splitview/split_view_controller.h

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37e21295f9a06f4800ff96b4db66f5beab63b35

commit f37e21295f9a06f4800ff96b4db66f5beab63b35
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 15 20:38:44 2017

Revert "tablet: Splitscreen window grid should move if a window can be snapped."

This reverts commit fbd6d1ac1e2516ef48761afd8c6288fd5c86a674.

Reason for revert: Failing on ASan LSan bot: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23029

Original change's description:
> tablet: Splitscreen window grid should move if a window can be snapped.
> 
> If there is currently no snapped window, and we drag an item which can be snapped when dropped, the window grid should shift to the opposite side, so that the phantom window does not cover any of the other window.
> 
> Test: ash_unittests "WindowSelectorTest.WindowGridSizeWhileDraggingWithSplitView"
> Bug:  753167 
> Change-Id: I695e71dbd0e35d0c0ff68f14fbad73dee57ceaa2
> Reviewed-on: https://chromium-review.googlesource.com/604400
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494438}

TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org

Change-Id: I289db9fb97b3f7913b67e8f5763c37c005fc2bb7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  753167 
Reviewed-on: https://chromium-review.googlesource.com/615905
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494529}
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/overview_window_drag_controller.h
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/window_grid.h
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/window_selector.h
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f37e21295f9a06f4800ff96b4db66f5beab63b35/ash/wm/splitview/split_view_controller.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96083081783f8062744efb0537b68d5cb28d1eb4

commit 96083081783f8062744efb0537b68d5cb28d1eb4
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Aug 16 18:15:19 2017

Reland "tablet: Splitscreen window grid should move if a window can be snapped."

This is a reland of fbd6d1ac1e2516ef48761afd8c6288fd5c86a674
Original change's description:
> tablet: Splitscreen window grid should move if a window can be snapped.
> 
> If there is currently no snapped window, and we drag an item which can be snapped when dropped, the window grid should shift to the opposite side, so that the phantom window does not cover any of the other window.
> 
> Test: ash_unittests "WindowSelectorTest.WindowGridSizeWhileDraggingWithSplitView"
> Bug:  753167 
> Change-Id: I695e71dbd0e35d0c0ff68f14fbad73dee57ceaa2
> Reviewed-on: https://chromium-review.googlesource.com/604400
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494438}

Bug:  753167 
Change-Id: Ia84d0d96cb0b515713cee2fdfc03dafd5370b6f0
Reviewed-on: https://chromium-review.googlesource.com/615790
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494865}
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/overview_window_drag_controller.h
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/window_grid.h
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/window_selector.h
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/96083081783f8062744efb0537b68d5cb28d1eb4/ash/wm/splitview/split_view_controller.h

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment