New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753160 link

Starred by 1 user
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ tjsavage@chromium.org
addyo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add the ability to customize the data provided when triggering a fake push event

Project Member Reported by mattgaunt@chromium.org, Aug 7 2017 
DevTools currently has the ability to trigger a push event with preset data, but there is no way for a developer to add their own data to trigger a push event.

If we allow developers to enter text to serve as the payload of the push event, they can easily test different edge cases within their code.
Push Event.png
36.0 KB View Download

Comment 1 by jonathan.garbee@chromium.org, Aug 9 2017 

Possible duplicate of #600902 ? Not quite sure since the upstream doesn't have any real description. Just a title that is semi-vague.

Comment 2 by eostroukhov@chromium.org, Sep 11 2017 

Suggested UI (note that push notification text field may resize to accomodiate multi-line payloads).
sw.png
36.6 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a806f2aaa56a131e97aad75a643cd3ac8f75c3f

commit 2a806f2aaa56a131e97aad75a643cd3ac8f75c3f
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Sat Sep 16 01:50:47 2017

[DevTools] Allow the user to customize SW events

Introduce a UI to customise push notification payload and Sync
notification tag.

Bug:  753160 , 753165 
Change-Id: Icc247a68632178c3f0c218e5dc54de75a3398464
Reviewed-on: https://chromium-review.googlesource.com/656531
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502469}
[modify] https://crrev.com/2a806f2aaa56a131e97aad75a643cd3ac8f75c3f/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-redundant-expected.txt
[modify] https://crrev.com/2a806f2aaa56a131e97aad75a643cd3ac8f75c3f/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-view-expected.txt
[modify] https://crrev.com/2a806f2aaa56a131e97aad75a643cd3ac8f75c3f/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/2a806f2aaa56a131e97aad75a643cd3ac8f75c3f/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkersView.css
[modify] https://crrev.com/2a806f2aaa56a131e97aad75a643cd3ac8f75c3f/third_party/WebKit/Source/devtools/front_end/ui/reportView.css

Comment 4 by pfeldman@chromium.org, Oct 4 2017

Owner: eostroukhov@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment