New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: 5
NextAction: 2017-08-08
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

Implement application to audit chromium git log

Project Member Reported by robert...@chromium.org, Aug 7 2017

Issue description

Metabug to track all tasks to implement this application as per the design doc go/commit-audit-app
 
The NextAction date has arrived: 2017-08-08

Comment 2 by st...@chromium.org, Aug 16 2017

Do we have sub-bugs to track all needed breakdown work?
Blockedon: 758480
Blockedon: 758846
Blockedon: 759196
Blockedon: 759800
Blockedon: 759841
Blockedon: 759837
Blockedon: 759835
Blockedon: 759844
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cb3f474b6a308b3f16def6415cae2859ce8ca611

commit cb3f474b6a308b3f16def6415cae2859ce8ca611
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 01 05:36:12 2017

Roll luci-go

infra/go/src/go.chromium.org/luci
eb2388ba gitiles: Implement forward log.

TBR=iannucci,dnj
BUG= 753158 

Change-Id: Ic19ccd91247b9902eec0833e980870fb3fc674ec
Reviewed-on: https://chromium-review.googlesource.com/647206
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/cb3f474b6a308b3f16def6415cae2859ce8ca611/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 1 2017

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a129aa5d08d0a063c58a479dcafaf38af988f5ab

commit a129aa5d08d0a063c58a479dcafaf38af988f5ab
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 01 06:30:12 2017

[cr-audit-commits] Provide basic index file.

All sites need an index pointing to the code and documentation.

R=stgao,agable,iannucci,chanli
BUG= 753158 

Change-Id: I990471f794b28e05314577c6fd7c26ca4408fcda
Reviewed-on: https://chromium-review.googlesource.com/634626
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[add] https://crrev.com/a129aa5d08d0a063c58a479dcafaf38af988f5ab/go/src/infra/appengine/cr-audit-commits/app/templates/pages/index.html
[modify] https://crrev.com/a129aa5d08d0a063c58a479dcafaf38af988f5ab/go/src/infra/appengine/cr-audit-commits/app/app.go

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9f009cb76267c533938a2ecb6e5cdf055803c1d5

commit 9f009cb76267c533938a2ecb6e5cdf055803c1d5
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 01 22:12:09 2017

[cr-audit-commits] Brief smoke test.

This handler performs a small query to each of the external services
that the app needs to communicate to.

It requires admin permission to run.

Bug:753158
Change-Id: I69778f1917a3097ae01dd28db847c42110fdec8e
R=stgao,dnj,iannucci,chanli
Reviewed-on: https://chromium-review.googlesource.com/634604
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[add] https://crrev.com/9f009cb76267c533938a2ecb6e5cdf055803c1d5/go/src/infra/appengine/cr-audit-commits/app/smoke.go
[modify] https://crrev.com/9f009cb76267c533938a2ecb6e5cdf055803c1d5/go/src/infra/appengine/cr-audit-commits/app/commit_scanner.go
[modify] https://crrev.com/9f009cb76267c533938a2ecb6e5cdf055803c1d5/go/src/infra/appengine/cr-audit-commits/app/app.go

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5c8e4bc1161714482078f573a16646b39a30eab6

commit 5c8e4bc1161714482078f573a16646b39a30eab6
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Sep 12 18:37:53 2017

[cr-audit-commits] Add cron.yaml, other fixes.

Minor fixes:
 - Increase logging to debug problems.
 - Make getAuthenticatedHTTPClient accept a variable number of scopes.
 - Rename gitilesScope to gerritScope.
 - Fix typo in commit auditor ndb query.

R=chanli,stgao
BUG= 753158 

Change-Id: If9aa49ba737e2015cd6cbbdfbbc4f10549529049
Reviewed-on: https://chromium-review.googlesource.com/661618
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/5c8e4bc1161714482078f573a16646b39a30eab6/go/src/infra/appengine/cr-audit-commits/app/commit_scanner.go
[modify] https://crrev.com/5c8e4bc1161714482078f573a16646b39a30eab6/go/src/infra/appengine/cr-audit-commits/app/utils.go
[modify] https://crrev.com/5c8e4bc1161714482078f573a16646b39a30eab6/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go
[add] https://crrev.com/5c8e4bc1161714482078f573a16646b39a30eab6/go/src/infra/appengine/cr-audit-commits/app/cron.yaml
[modify] https://crrev.com/5c8e4bc1161714482078f573a16646b39a30eab6/go/src/infra/appengine/cr-audit-commits/app/smoke.go

Blocking: 766193
Blockedon: 767614
The initial version of this app is live. Only remaining blocker is enabling billing.
Status: Fixed (was: Started)
Blocking: 705790

Sign in to add a comment