New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753156 link

Starred by 1 user
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ tjsavage@chromium.org
addyo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Service Workers Panel should link errors to the console NOT have in the tab

Project Member Reported by mattgaunt@chromium.org, Aug 7 2017 
When you visit it a page which has a service worker which fails to register, errors will be logged in two place. It'll be logged in the console (which has full stack trace) and it'll be added under the service worker panel, but there is no stack and the formatting isn't as featured / pleasant at the console.

Change the "Details" link to open the Console tab rather than show a collapsed view with the error text

What steps will reproduce the problem?
(1) Visit https://cumbersome-streetcar.glitch.me/
(2) Open DevTools and notice the error in the console
(3) Now notice the error in the service worker tab under the "details" section.
devtools details change.png
111 KB View Download

Comment 1 by mattgaunt@chromium.org, Aug 7 2017 

If this is not desirable, could we link change the behavior of clicking on the file + line number under the error, which currently opens a new tab to the URL of the service worker source and instead open the file under the sources tab on the line number that throw the error.

Comment 2 by eostroukhov@chromium.org, Aug 28 2017 

The proposal is to only show error count and to show it as a clickable link that opens the console view. I attached a screenshot with proposed enhancements.
updated-redundant-display.png
25.0 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/347b2e0acdc8b10f264e4f7ff519ec78e0a734a4

commit 347b2e0acdc8b10f264e4f7ff519ec78e0a734a4
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Fri Sep 15 23:10:21 2017

[DevTools] Cleanup service workers display.

1. Removed errors list and associated links. Error count is now a link
   that opens the console view.
2. Reduntant workers now display name and state.
3. Fixed a bug when new shadow roots where added to the fields on every
   refresh, triggering a warning and some confusing UI problems.

Bug:  753156 
Change-Id: I865eb1fdaa21cdbbbf5554844ae965bfebbf5ac4
Reviewed-on: https://chromium-review.googlesource.com/639455
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502429}
[modify] https://crrev.com/347b2e0acdc8b10f264e4f7ff519ec78e0a734a4/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-redundant-expected.txt
[modify] https://crrev.com/347b2e0acdc8b10f264e4f7ff519ec78e0a734a4/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-view-expected.txt
[modify] https://crrev.com/347b2e0acdc8b10f264e4f7ff519ec78e0a734a4/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/347b2e0acdc8b10f264e4f7ff519ec78e0a734a4/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkersView.css

Comment 4 by eostroukhov@chromium.org, Sep 15 2017

Owner: eostroukhov@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment