handle multiple instances of --enable-blink-features |
|||
Issue descriptionThe bug is found when running virtual layout tests on try bot linux_layout_tests_layout_ng. Minimal repro: run the following command line run-webkit-tests --additional-driver-flag=--enable-blink-features=LayoutNG virtual/mojo-loading/ The problem is that two --enable-blink-features flags are passed to content_shell: - --additional-driver-flag adds --enable-blink-features=LayoutNG - virtual/mojo test suite adds another --enable-blink-features=LoadingWithMojo And the later overwrites the former. To make things work, the two flags have to be some how combined into one --enable-blink-features.
,
Aug 15 2017
,
Aug 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/773cdbaaad69b9c78f9dd212ece0214e2652985d commit 773cdbaaad69b9c78f9dd212ece0214e2652985d Author: Steve Kobes <skobes@chromium.org> Date: Sat Aug 19 22:03:05 2017 Support multiple instances of --{enable,disable}-blink-features. Bug: 753141 Change-Id: I61aeeaa4a1e27eacd5c8a66c4f45beb591485b85 Reviewed-on: https://chromium-review.googlesource.com/617906 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#495828} [modify] https://crrev.com/773cdbaaad69b9c78f9dd212ece0214e2652985d/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/773cdbaaad69b9c78f9dd212ece0214e2652985d/content/child/runtime_features.cc [modify] https://crrev.com/773cdbaaad69b9c78f9dd212ece0214e2652985d/content/common/content_switches_internal.cc [modify] https://crrev.com/773cdbaaad69b9c78f9dd212ece0214e2652985d/content/common/content_switches_internal.h [add] https://crrev.com/773cdbaaad69b9c78f9dd212ece0214e2652985d/content/common/content_switches_internal_unittest.cc [modify] https://crrev.com/773cdbaaad69b9c78f9dd212ece0214e2652985d/content/test/BUILD.gn
,
Aug 19 2017
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/732536e97888e634ae1246aee9b06c95c4c99ab0 commit 732536e97888e634ae1246aee9b06c95c4c99ab0 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Mon Aug 21 23:05:38 2017 Remove failure lines due to crbug.com/753141 from LayoutNG flag expectations As crbug.com/753141 is fixed, this CL removes the failures lines to make the LayoutNG flag expectations file clean. Bug: 753141 Change-Id: I7aee6c348175c0a305694793f02e4b59c678f36d Reviewed-on: https://chromium-review.googlesource.com/624400 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#496107} [modify] https://crrev.com/732536e97888e634ae1246aee9b06c95c4c99ab0/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG |
|||
►
Sign in to add a comment |
|||
Comment 1 by skobes@chromium.org
, Aug 7 2017