New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753127 link

Starred by 1 user
Status: Fixed
Owner:
█ phulce@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Devtools: Audits track used vs. source size of images

Project Member Reported by phulce@chromium.org, Aug 7 2017 
The current approach (https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/byte-efficiency/uses-responsive-images.js#L47) the audits panel takes to finding oversized images is slow and unable to account for images that were used while the page was loading.

Adding instrumentation to the PaintImage trace event with the target and source size would eliminate the need for this hack and improve coverage of image usage scenarios.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2fd3e10682b473d12a6b4fe65c9a260b772e412

commit c2fd3e10682b473d12a6b4fe65c9a260b772e412
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu Aug 24 03:11:32 2017

DevTools: Add size information to PaintImage trace event

* Adds x, y, width, height, srcWidth, srcHeight to PaintImage
  trace event in disabled-by-default-devtools.timeline.

BUG= 753127 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I74ed5e14767d97c784d27c0d11f4fca3c676997b
Reviewed-on: https://chromium-review.googlesource.com/607241
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496934}
[add] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-image-expected.txt
[add] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-image.html
[modify] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/Source/core/paint/BoxPainterBase.cpp
[modify] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/Source/core/paint/ImagePainter.cpp
[modify] https://crrev.com/c2fd3e10682b473d12a6b4fe65c9a260b772e412/third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp

Comment 2 by phulce@chromium.org, Aug 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment