New issue
Advanced search Search tips

Issue 753125 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
aboxhall@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Table rows are ignored when they are not the direct child of the table object

Project Member Reported by nek...@chromium.org, Aug 7 2017 
When building the accessibility tree we ignore any table rows that are not the direct children of the table object. This happens both for HTML tables and ARIA grids. However there might be cases on the Web where webpage authors have place another element or elements in between the table element and its rows. This element or elements might be important for accessibility and thereby cannot be ignored.
For example:
<table>
<div role="main">
<tr>
...
</tr>
</div>
</table>
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9b5b94d0649d6a2b0fb3c9e716476bec291208

commit 3d9b5b94d0649d6a2b0fb3c9e716476bec291208
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Apr 18 21:36:38 2018

Introduce AXTableInfo to compute info about tables from an AXTree.

This new class computes information about a table in an AXTree,
including its dimensions, headers, and a mapping from row/column
index to a cell's node ID. It's computed from an AXTree on-demand
and cached until the tree changes.

Subsequent changes will switch browser-side code to use this
interface instead of the equivalent information provided by Blink,
and then remove some of the table-handling code from Blink.

See bug 832289 for more details on the planned refactoring.

Bug: 832289, 651614, 789748, 753125,
Change-Id: I29b31833426b69cb73266829e8f577785aa6fce6
Reviewed-on: https://chromium-review.googlesource.com/1011229
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551832}
[modify] https://crrev.com/3d9b5b94d0649d6a2b0fb3c9e716476bec291208/ui/accessibility/BUILD.gn
[add] https://crrev.com/3d9b5b94d0649d6a2b0fb3c9e716476bec291208/ui/accessibility/ax_table_info.cc
[add] https://crrev.com/3d9b5b94d0649d6a2b0fb3c9e716476bec291208/ui/accessibility/ax_table_info.h
[add] https://crrev.com/3d9b5b94d0649d6a2b0fb3c9e716476bec291208/ui/accessibility/ax_table_info_unittest.cc
[modify] https://crrev.com/3d9b5b94d0649d6a2b0fb3c9e716476bec291208/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/3d9b5b94d0649d6a2b0fb3c9e716476bec291208/ui/accessibility/ax_tree.h
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65582a0a4cdbd7200afa163cdfb542236e5c3a55

commit 65582a0a4cdbd7200afa163cdfb542236e5c3a55
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Apr 24 23:21:35 2018

Use AXTableInfo to dynamically compute table properties.

This is a follow-up to http://crrev.com/c/1011229, which introduced
AXTableInfo. In this change, Mac and Windows accessibility code uses
AXTableInfo to get cell IDs, column headers, and row headers, rather
than relying on those attributes from Blink.

This speeds up Blink serialization and will make it easier for our
table handling code to be even more fast and robust.

TBR=estark@chromium.org

Bug: 832289, 651614, 789748, 753125
Change-Id: I4d859e0a5973f172b1b3e587ad871607d127f6cd
Reviewed-on: https://chromium-review.googlesource.com/1012447
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553354}
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/browser/accessibility/cross_platform_accessibility_browsertest.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/ax_tree_combiner_unittest.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_platform_node_unittest.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_system_caret_win.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/ax_system_caret_win.h
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/65582a0a4cdbd7200afa163cdfb542236e5c3a55/ui/views/accessibility/native_view_accessibility_base.h
►

Sign in to add a comment