Look into switching scroll node namespace to kScroll from kScrollTranslation. |
||
Issue descriptionOn review of ScrollAnimatorCompositorCoordinator we find that ScrollableArea::LayerForScrolling ends up, for PaintLayerScrollableArea, returning an element id based on the owning layer and using the CompositorElementIdNamespace::kScroll namespace (see CompositedLayerMapping::UpdateScrollingLayers). PaintPropertyTreeBuilder uses kScrollTranslation. pdr@ thinks perhaps we should be using kScroll.
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a46f9f546de805609489acad32eb0b8c7337095c commit a46f9f546de805609489acad32eb0b8c7337095c Author: pdr <pdr@chromium.org> Date: Tue Aug 08 17:26:01 2017 [SPV2] Switch to kScroll namespace from kScrollTranslation After [1], scrolling compositor element ids are set on scroll nodes and not scroll translation nodes. Though a scroll translation node will always be required in these cases, there is no reason to disambiguate kScroll from kScrollTranslation. This patch also adds a DCHECK that ScrollPaintPropertyNodes only have kScroll-namespaced compositor element ids set. [1] https://chromium-review.googlesource.com/c/602927 Bug: 738613 , 753100 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4c28250c0b1446f75e0740b1ac93f3e63af63fa7 Reviewed-on: https://chromium-review.googlesource.com/604472 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Walter Korman <wkorman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#492682} [modify] https://crrev.com/a46f9f546de805609489acad32eb0b8c7337095c/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/a46f9f546de805609489acad32eb0b8c7337095c/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp [modify] https://crrev.com/a46f9f546de805609489acad32eb0b8c7337095c/third_party/WebKit/Source/platform/graphics/CompositorElementId.h [modify] https://crrev.com/a46f9f546de805609489acad32eb0b8c7337095c/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp [modify] https://crrev.com/a46f9f546de805609489acad32eb0b8c7337095c/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h
,
Aug 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, Aug 8 2017