New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753098 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

EarlGrey grey_typeText fails on iOS 11 iPad

Project Member Reported by liaoyuke@chromium.org, Aug 7 2017

Issue description

EarlGrey grey_typeText fails on iOS 11 iPad
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e20955cf88073ba9130c871c14f67794764b4485

commit e20955cf88073ba9130c871c14f67794764b4485
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Aug 08 00:44:40 2017

Disable tests on iOS 11 iPad that uses grey_typeText.

EarlGrey's grey_typeText has a bug on iOS 11 iPad that's causing tests
to fail or hang indefinitely.

Bug: 753098
Change-Id: I914e3b058e5bc6a235311c2537f8a6e0d4af3643
Reviewed-on: https://chromium-review.googlesource.com/604497
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492474}
[modify] https://crrev.com/e20955cf88073ba9130c871c14f67794764b4485/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/e20955cf88073ba9130c871c14f67794764b4485/ios/showcase/payments/sc_payments_editor_egtest.mm
[modify] https://crrev.com/e20955cf88073ba9130c871c14f67794764b4485/ios/showcase/payments/sc_payments_picker_egtest.mm

Is this something that EarlGrey needs to fix? If so, is there a github bug for it?
Yes, it is something that EG needs to fix, and here is the bugnizer bug: https://b.corp.google.com/issues/64399456, no github bug yet, but I can file one you think it's necessary.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/84200b67e2bdfd38a94ec7600e419c950ce86445

commit 84200b67e2bdfd38a94ec7600e419c950ce86445
Author: Yuke Liao <liaoyuke@google.com>
Date: Tue Aug 08 04:53:02 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19a4ec7b418d9672991c68057bbb084edbbfd76f

commit 19a4ec7b418d9672991c68057bbb084edbbfd76f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Aug 08 06:25:38 2017

Disable testFindInPage on iOS 11 iPad.

EarlGrey's grey_typeText has a bug on iOS 11 iPad that's causing tests
to fail or hang indefinitely, and this CL disabled testFindInPage,
which uses grey_typeText.

Bug: 753098
Change-Id: I0287818da6251b50f983ec4507b5eb571fe3f39f
Reviewed-on: https://chromium-review.googlesource.com/605053
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492553}
[modify] https://crrev.com/19a4ec7b418d9672991c68057bbb084edbbfd76f/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/19a4ec7b418d9672991c68057bbb084edbbfd76f/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3529cc6b83fd97df007fbed149014f6c26fb88f4

commit 3529cc6b83fd97df007fbed149014f6c26fb88f4
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Aug 11 11:00:34 2017

Disable tests in qr scanner that uses grey_typeText.

EarlGrey has a bug on iOS 11 iPad that grey_typeText is causing tests
to fail or hang indefinitely.

testReceivingQRScannerURLResultAndEditingTheURL and
testReceivingQRScannerSearchQueryResultAndEditingTheQuery needs to type
something into the omnibox, so disabling them on iOS 11, iPad.

Bug: 753098
Change-Id: I629669ef46bf46d513eeccd0946d3e123729dbea
Reviewed-on: https://chromium-review.googlesource.com/611945
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493698}
[modify] https://crrev.com/3529cc6b83fd97df007fbed149014f6c26fb88f4/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/3529cc6b83fd97df007fbed149014f6c26fb88f4/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df010533bdc73bfcf49fe3ca8054b7cd24b39a10

commit df010533bdc73bfcf49fe3ca8054b7cd24b39a10
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Aug 11 16:02:16 2017

Fix find in page egtests on iOS 11 iPad.

This CL fixes the find in page egtests on iOS 11 iPad by replacing
grey_typeText with grey_replaceText.

Bug: 753098
Change-Id: I5c03ad26f3dda9e8bb9f97078cc00d81b81fb27d
Reviewed-on: https://chromium-review.googlesource.com/611284
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493760}
[modify] https://crrev.com/df010533bdc73bfcf49fe3ca8054b7cd24b39a10/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/df010533bdc73bfcf49fe3ca8054b7cd24b39a10/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1241b45ed55a9986d024594921589d7c22cb334f

commit 1241b45ed55a9986d024594921589d7c22cb334f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Aug 11 20:19:09 2017

Disable tests in ToolbarTestCase that uses grey_typeText.

EarlGrey has a bug on iOS 11 iPad that grey_typeText is causing tests
to fail or hang indefinitely.

testToolbarOmniboxHideKeyboard and testOmniboxClearTextButton needs to
type something into the omnibox, so disabling them on iOS 11, iPad.

Bug: 753098
Change-Id: I5fb0f64215483e6b6bb588c54aa2f7f9c41f913f
Reviewed-on: https://chromium-review.googlesource.com/612440
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493840}
[modify] https://crrev.com/1241b45ed55a9986d024594921589d7c22cb334f/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae5d58af1439acbbc521605911afc822ec4a222

commit 6ae5d58af1439acbbc521605911afc822ec4a222
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Aug 14 15:52:07 2017

Fix bookmark egtests on iOS 11.

This CL replaces grey_typeText with grey_replaceText whenever possible.

There are two reasons for this change:

1. We should favor grey_replaceText over grey_typeText because 
grey_replaceText is faster and more stable.

2. EarlGrey has a bug on iOS 11 where grey_typeText hangs indefinitely
on iPad.

Bug: 753098, 644730,  748748 
Change-Id: Idcdde77c8884a3a7ff616377afc48611d48e22f8
Reviewed-on: https://chromium-review.googlesource.com/611254
Reviewed-by: Ramya Sharma <ramyasharma@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494056}
[modify] https://crrev.com/6ae5d58af1439acbbc521605911afc822ec4a222/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc22e664bca9ff775783bcac786bb35d84cd9de4

commit bc22e664bca9ff775783bcac786bb35d84cd9de4
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Aug 14 19:26:13 2017

Disable testSearchHistory on iOS 11 iPad.

testSearchHistory needs to type something into the search text field,
however, either grey_typeText or grey_replaceText work, so disabling
it on iOS 11, iPad.

Bug: 753098
Change-Id: I16979b6437ec40fb4eb79547b9742bf43758cc0c
Reviewed-on: https://chromium-review.googlesource.com/610684
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494131}
[modify] https://crrev.com/bc22e664bca9ff775783bcac786bb35d84cd9de4/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/bc22e664bca9ff775783bcac786bb35d84cd9de4/ios/chrome/browser/ui/history/history_ui_egtest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d77d9f661c63c0e3fe60ab5f1167efc7e2c94c19

commit d77d9f661c63c0e3fe60ab5f1167efc7e2c94c19
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Aug 14 23:04:10 2017

Disable testShowJavaScriptPromptCancelled on iOS 11 iPad.

testSearchHistory needs to type something into the alert text field,
however, neither grey_typeText nor grey_replaceText works, so disabling
it on iOS 11, iPad.

Bug: 753098
Change-Id: Idc3d06988f04eb5cdba3a1dc00dac8d8a87b9335
Reviewed-on: https://chromium-review.googlesource.com/611610
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494228}
[modify] https://crrev.com/d77d9f661c63c0e3fe60ab5f1167efc7e2c94c19/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm

Blocking: -747114
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6daa0e726f73513ef748b32aeaf757594440282

commit b6daa0e726f73513ef748b32aeaf757594440282
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Aug 15 20:33:56 2017

Disable testShowJavaScriptPromptOK on iOS 11 iPad.

EarlGrey has a bug on iOS 11 iPad that is causing grey_typeText to fail
or hang indefinitely.

testShowJavaScriptPromptOK needs to type something into the alert text
field, so disabling it on iOS 11, iPad.

Bug: 753098
Change-Id: If770904f92dd2c323867d0bc7b0592337041b33c
Reviewed-on: https://chromium-review.googlesource.com/615543
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494525}
[modify] https://crrev.com/b6daa0e726f73513ef748b32aeaf757594440282/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm

This will block M62 Beta, any update here? Should this still be opened?
Can we mark this bug as ThirdParty, as we're waiting for EarlGrey to fix it?

I think the severity is a little lower, if we replaced many of them with grey_replaceText, fixing the problem and making tests faster. Additionally, the tests still run on non-iOS 11 iPads, and iOS 11 phones, correct?
Labels: -ReleaseBlock-Beta -M-62
Status: ExternalDependency (was: Assigned)
Yes, that makes sense. Marking it as ThirdParty and removing RBB label.
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ca5963f858ce1fa69eb2e282724fa75ff5a1cda

commit 9ca5963f858ce1fa69eb2e282724fa75ff5a1cda
Author: Rohit Rao <rohitrao@google.com>
Date: Wed Sep 13 12:45:18 2017

[ios] Disables testInputAccessoryViewNavigationButtons on iOS 11.

This test was already disabled on iOS 11 iPad, but it has started failing on
iPhone as well in the iOS 11 GM build.

BUG=753098

Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83
Reviewed-on: https://chromium-review.googlesource.com/664837
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501604}
[modify] https://crrev.com/9ca5963f858ce1fa69eb2e282724fa75ff5a1cda/ios/showcase/payments/sc_payments_editor_egtest.mm

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 22 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/894a04d10d2c18eaf3f930ee33c97f1b2413c587

commit 894a04d10d2c18eaf3f930ee33c97f1b2413c587
Author: Rohit Rao <rohitrao@google.com>
Date: Fri Sep 22 18:51:30 2017

[ios] Disables testInputAccessoryViewNavigationButtons on iOS 11.

This test was already disabled on iOS 11 iPad, but it has started failing on
iPhone as well in the iOS 11 GM build.

BUG=753098

Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83
Reviewed-on: https://chromium-review.googlesource.com/664837
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501604}(cherry picked from commit 9ca5963f858ce1fa69eb2e282724fa75ff5a1cda)
Reviewed-on: https://chromium-review.googlesource.com/679294
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#402}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/894a04d10d2c18eaf3f930ee33c97f1b2413c587/ios/showcase/payments/sc_payments_editor_egtest.mm

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/651834b6761008f00818a7b45f12207483fc3282

commit 651834b6761008f00818a7b45f12207483fc3282
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 26 14:13:38 2017

Reenables SCPaymentsEditorTestCase.testInputAccessoryViewNavigationButtons

- Replaces grey_typeText with grey_replaceText so that the test can be
  enabled in iOS11.
- Modifies the test so that the navigation buttons are not used to go to
  the previous editor field. The reason for that changes is that on iPhone
  5/5s, due to the size of the screen, the previous field may be under the
  scroll and therefore the "previous" navigation button is disabled.

Bug: 753098
Change-Id: I3343014e8374cea6bbfa3031a92f631ad7d9039d
Reviewed-on: https://chromium-review.googlesource.com/682341
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504359}
[modify] https://crrev.com/651834b6761008f00818a7b45f12207483fc3282/ios/showcase/payments/sc_payments_editor_egtest.mm

Owner: ----

Sign in to add a comment