New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753086 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 738514



Sign in to add a comment

Get-Printer-Attributes Failing Unexpectedly

Project Member Reported by skau@chromium.org, Aug 7 2017

Issue description

Printers that advertise support for IPP via DNS-SD are not responding to our IPP queries.  They are however, handling the CUPS print requests.  Figure out why.

Issue is blocking accurate metrics collection and PPD guessing.
 

Comment 1 by skau@chromium.org, Aug 7 2017

Blocking: 738514
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcba9cb6188c6f3df986c93d4ca50eec39929fa3

commit fcba9cb6188c6f3df986c93d4ca50eec39929fa3
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 08 23:50:40 2017

Add a histogram to track IPP Attributes failures.

Requests for IPP Get-Attributes seem to be failing more than expected.
Add a metric to track the failure rate so we can verify when it's fixed.

Bug:  753086 
Change-Id: I536e5d755585f04eddb561d4c7f34f48e7209fff
Reviewed-on: https://chromium-review.googlesource.com/605054
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492779}
[modify] https://crrev.com/fcba9cb6188c6f3df986c93d4ca50eec39929fa3/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/fcba9cb6188c6f3df986c93d4ca50eec39929fa3/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2017

Comment 4 by skau@chromium.org, Aug 15 2017

Cc: skau@chromium.org
 Issue 755408  has been merged into this issue.

Comment 5 by skau@chromium.org, Aug 15 2017

Labels: -Pri-2 M-61 Pri-1
Looks like the request is invalid in many cases.  Bumping priority.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d5e7fb9a6ffbf80184091a23ed9e8450e514a56

commit 8d5e7fb9a6ffbf80184091a23ed9e8450e514a56
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 15 20:45:35 2017

Use the full uri for the printer-uri in Get-Printer-Attributes.

We've been using the relative path for the printer-uri value in
Get-Printer-Attributes requests.  After further testing, limited
printers support the relative path and require the full uri.

Bug:  753086 
Change-Id: I75c6f82b2d62f18a299444d20b13f40d9404b42b
Reviewed-on: https://chromium-review.googlesource.com/613801
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494532}
[modify] https://crrev.com/8d5e7fb9a6ffbf80184091a23ed9e8450e514a56/printing/backend/cups_jobs.cc

Comment 7 by skau@chromium.org, Aug 15 2017

Status: Fixed (was: Started)

Comment 8 by skau@chromium.org, Aug 15 2017

Labels: Merge-Request-61
Requesting merge back to M61.  This should improve detection of autoconf printers significantly.

Comment 9 by ketakid@google.com, Aug 15 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c37aeb9d427e83c036f10e0ee841a70bf5ad364

commit 1c37aeb9d427e83c036f10e0ee841a70bf5ad364
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:39:02 2017

Add a histogram to track IPP Attributes failures.

Requests for IPP Get-Attributes seem to be failing more than expected.
Add a metric to track the failure rate so we can verify when it's fixed.

TBR=skau@chromium.org

(cherry picked from commit fcba9cb6188c6f3df986c93d4ca50eec39929fa3)

Bug:  753086 
Change-Id: I536e5d755585f04eddb561d4c7f34f48e7209fff
Reviewed-on: https://chromium-review.googlesource.com/605054
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492779}
Reviewed-on: https://chromium-review.googlesource.com/619698
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#660}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/1c37aeb9d427e83c036f10e0ee841a70bf5ad364/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/1c37aeb9d427e83c036f10e0ee841a70bf5ad364/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e1dbc79ad36fab5ce740b76746fcea70317eff0

commit 9e1dbc79ad36fab5ce740b76746fcea70317eff0
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:42:20 2017

Require encryption for IPPS printers in Get-Printer-Attributes requests.

Require encryption if we see an ipps scheme.  IPPS requests were being
rejected otherwise.

TBR=skau@chromium.org

(cherry picked from commit a2780bb650cd4c72357152d14a10371127f90bd1)

Bug:  753086 
Change-Id: Ifec14e7fa036027c7874d6b684c8faa089deb75e
Reviewed-on: https://chromium-review.googlesource.com/609374
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493669}
Reviewed-on: https://chromium-review.googlesource.com/619927
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#661}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9e1dbc79ad36fab5ce740b76746fcea70317eff0/chrome/browser/chromeos/printing/printer_info.h
[modify] https://crrev.com/9e1dbc79ad36fab5ce740b76746fcea70317eff0/chrome/browser/chromeos/printing/printer_info_cups.cc
[modify] https://crrev.com/9e1dbc79ad36fab5ce740b76746fcea70317eff0/chrome/browser/chromeos/printing/printer_info_stub.cc
[modify] https://crrev.com/9e1dbc79ad36fab5ce740b76746fcea70317eff0/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/9e1dbc79ad36fab5ce740b76746fcea70317eff0/printing/backend/cups_jobs.cc
[modify] https://crrev.com/9e1dbc79ad36fab5ce740b76746fcea70317eff0/printing/backend/cups_jobs.h

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29756680a177f7b4561a7c6ec7636f2f352c5ede

commit 29756680a177f7b4561a7c6ec7636f2f352c5ede
Author: Sean Kau <skau@chromium.org>
Date: Fri Aug 18 21:07:09 2017

Use the full uri for the printer-uri in Get-Printer-Attributes.

We've been using the relative path for the printer-uri value in
Get-Printer-Attributes requests.  After further testing, limited
printers support the relative path and require the full uri.

TBR=skau@chromium.org

(cherry picked from commit 8d5e7fb9a6ffbf80184091a23ed9e8450e514a56)

Bug:  753086 
Change-Id: I75c6f82b2d62f18a299444d20b13f40d9404b42b
Reviewed-on: https://chromium-review.googlesource.com/613801
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494532}
Reviewed-on: https://chromium-review.googlesource.com/621291
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#684}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/29756680a177f7b4561a7c6ec7636f2f352c5ede/printing/backend/cups_jobs.cc

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment