Failing css-transforms-2 web platform tests |
|
Issue description
When we remove css-transforms-2 from
third_party/WebKit/LayoutTests/NeverFixTests
the following tests fail:
[1/21] external/wpt/css/css-transforms-2/transform3d-matrix3d-001.html failed unexpectedly (reference mismatch)
[2/21] external/wpt/css/css-transforms-2/transform3d-sorting-004.html failed unexpectedly (reference mismatch)
[3/21] external/wpt/css/css-transforms-2/transform3d-perspective-003.html failed unexpectedly (reference mismatch)
[4/21] external/wpt/css/css-transforms-2/transform3d-preserve3d-013.html failed unexpectedly (reference mismatch)
[5/21] external/wpt/css/css-transforms-2/transform3d-scale-006.html failed unexpectedly (reference mismatch)
[6/21] external/wpt/css/css-transforms-2/transform3d-image-scale-001.html failed unexpectedly (reference mismatch)
[7/21] external/wpt/css/css-transforms-2/ttwf-css-3d-polygon-cycle.html failed unexpectedly (reference mismatch)
[8/21] external/wpt/css/css-transforms-2/transform3d-image-scale-002.html failed unexpectedly (reference mismatch)
[9/21] external/wpt/css/css-transforms-2/transform3d-scale-007.html failed unexpectedly (reference mismatch)
[10/21] external/wpt/css/css-transforms-2/transform-3d-rotateY-stair-below-001.xht failed unexpectedly (reference mismatch)
[11/21] external/wpt/css/css-transforms-2/transform3d-sorting-002.html failed unexpectedly (reference mismatch)
[12/21] external/wpt/css/css-transforms-2/transform3d-perspective-005.html failed unexpectedly (reference mismatch)
[13/21] external/wpt/css/css-transforms-2/transform3d-sorting-006.html failed unexpectedly (reference mismatch)
[14/21] external/wpt/css/css-transforms-2/transform3d-scale-005.html failed unexpectedly (reference mismatch)
[15/21] external/wpt/css/css-transforms-2/transform3d-perspective-004.html failed unexpectedly (reference mismatch)
[16/21] external/wpt/css/css-transforms-2/backface-visibility-hidden-001.html failed unexpectedly (reference mismatch)
[17/21] external/wpt/css/css-transforms-2/transform3d-rotatex-perspective-003.html failed unexpectedly (reference mismatch)
[18/21] external/wpt/css/css-transforms-2/ttwf-css-3d-polygon-cycle-mismatch.html failed unexpectedly (reference mismatch)
[19/21] external/wpt/css/css-transforms-2/rotate_y_45deg.html failed unexpectedly (reference mismatch)
[20/21] external/wpt/css/css-transforms-2/transform3d-preserve3d-010.html failed unexpectedly (reference mismatch)
[21/21] external/wpt/css/css-transforms-2/rotate_x_45deg.html failed unexpectedly (reference mismatch)
Preliminary analysis by Stephen Chenney:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bY4v78aN8to/eLUPbq__AQAJ
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd4865395d480f3863f274afcee8f57f206c81c0 commit fd4865395d480f3863f274afcee8f57f206c81c0 Author: Stephen Chenney <schenney@chromium.org> Date: Tue Aug 08 17:48:08 2017 Claim ownership of wpt tests for the paint team The tests are now part of Blink regular test suite, and the paint team owns the functionality that is tested. So we should own the tests. R=foolip@chromium.org,chrishtr@chromium.org BUG=753080 Change-Id: Ic6d903c9e9ab4ac1a3abbbd3a1d9ba9e8141c98b Reviewed-on: https://chromium-review.googlesource.com/606167 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#492693} [add] https://crrev.com/fd4865395d480f3863f274afcee8f57f206c81c0/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms-2/OWNERS [add] https://crrev.com/fd4865395d480f3863f274afcee8f57f206c81c0/third_party/WebKit/LayoutTests/external/wpt/images/OWNERS [modify] https://crrev.com/fd4865395d480f3863f274afcee8f57f206c81c0/third_party/WebKit/LayoutTests/external/wpt/svg/OWNERS
,
Aug 25 2017
My informal breakdown would be as follows: Expectations differ from Blink's rendering by 1px. external/wpt/css/css-transforms-2/backface-visibility-hidden-001.html external/wpt/css/css-transforms-2/rotate_x_45deg.html external/wpt/css/css-transforms-2/rotate_y_45deg.html external/wpt/css/css-transforms-2/transform3d-preserve3d-010.html external/wpt/css/css-transforms-2/transform3d-preserve3d-013.html external/wpt/css/css-transforms-2/transform3d-scale-005.html external/wpt/css/css-transforms-2/transform3d-scale-006.html external/wpt/css/css-transforms-2/transform-3d-rotateY-stair-below-001.xht No transformed image in expectation external/wpt/css/css-transforms-2/transform3d-image-scale-001.html external/wpt/css/css-transforms-2/transform3d-image-scale-002.html Expectation appears to lack perspective external/wpt/css/css-transforms-2/transform3d-perspective-003.html external/wpt/css/css-transforms-2/transform3d-perspective-004.html external/wpt/css/css-transforms-2/transform3d-perspective-005.html Different sorting order external/wpt/css/css-transforms-2/transform3d-sorting-002.html external/wpt/css/css-transforms-2/transform3d-sorting-004.html external/wpt/css/css-transforms-2/transform3d-sorting-006.html external/wpt/css/css-transforms-2/ttwf-css-3d-polygon-cycle-mismatch.html external/wpt/css/css-transforms-2/ttwf-css-3d-polygon-cycle.html Other mismatch external/wpt/css/css-transforms-2/transform3d-matrix3d-001.html external/wpt/css/css-transforms-2/transform3d-rotatex-perspective-003.html external/wpt/css/css-transforms-2/transform3d-scale-007.html
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5a1bfee03cbc993159d08b2d4212dd76519a9ad commit c5a1bfee03cbc993159d08b2d4212dd76519a9ad Author: Eric Willigers <ericwilligers@chromium.org> Date: Fri Aug 25 21:51:55 2017 css-transforms-2: Enable most web platform tests Instead of disabling all the tests, we now disable only the tests that are known to fail. Preliminary analysis by Stephen Chenney: https://groups.google.com/a/chromium.org/d/msg/blink-dev/bY4v78aN8to/eLUPbq__AQAJ BUG=753080 Change-Id: I162c7bdfa9fbe44f13d87fea719cd660d113a311 Reviewed-on: https://chromium-review.googlesource.com/634783 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#497552} [modify] https://crrev.com/c5a1bfee03cbc993159d08b2d4212dd76519a9ad/third_party/WebKit/LayoutTests/NeverFixTests
,
Sep 12 2017
For tests like transform3d-scale-005.html, should we have exact rotations by multiples of 90degrees? We could identify such cases by computing mod with 90 before converting to radians.
,
Sep 12 2017
Re comment 5: is transform3d-scale-005.html passing on Firefox? I'm pretty sure that Firefox snaps transforms to pixels, whereas Chrome snaps pre-transform and then applies the transform as a floating-point mapping. This is a real and significant compatibility issue. |
|
►
Sign in to add a comment |
|
Comment 1 by schenney@chromium.org
, Aug 7 2017Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)