New issue
Advanced search Search tips

Issue 753073 link

Starred by 3 users
Status: Fixed
Owner:
adamk@chromium.org
Closed: Mar 2018
Cc:
l...@chromium.org
robertma@chromium.org
gsat...@chromium.org
adamk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 801556
issue 802400
issue 807192
Blocking:
issue 651774



Sign in to add a comment

Update layout tests to work with v8's --harmony-function-tostring

Reported by jwo...@igalia.com, Aug 7 2017 
v8 is going to enable --harmony-function-tostring by default. For background, see:
https://bugs.chromium.org/p/v8/issues/detail?id=4958
https://chromium-review.googlesource.com/c/546941

--harmony-function-tostring canonicalizes the formatting of Function.prototype.toString(), which can change the result depending on how your function was declared. Additionally, the line numbers reported in stack traces and by the debugger will be different for functions created through the Function constructor in some cases.

This issue is to update the layout tests to work with the new behavior. Some tests can be adjusted to pass both with and without --harmony-function-tostring. Some tests will need rebaselining once the switch is enabled.

Comment 1 by jbanavatu@chromium.org, Aug 10 2017

Labels: TE-NeedsTriageHelp
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/585ea5f5a377015a4b600a02170fa6ff4740a73e

commit 585ea5f5a377015a4b600a02170fa6ff4740a73e
Author: Josh Wolfe <jwolfe@igalia.com>
Date: Mon Dec 18 22:15:56 2017

NeedsManualRebaseline for --harmony-function-tostring

Bug:  chromium:753073 
Change-Id: Iab9e4f4f0a8d09b1d4da0ccd7c27cde49f5bb7b7
Reviewed-on: https://chromium-review.googlesource.com/695801
Commit-Queue: Josh Wolfe <jwolfe@igalia.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524830}
[modify] https://crrev.com/585ea5f5a377015a4b600a02170fa6ff4740a73e/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by robertma@chromium.org, Dec 20 2017

Cc: robertma@chromium.org
Looks like harmony-function-tostring was reverted to off by default in v8?

Once it's re-enabled, I'll look into rebaselining these tests.

Comment 4 by jwo...@igalia.com, Dec 20 2017 

Yes. Some bots caught a GC bug in the implementation, which is fixed now. And then some new chromium tests uncovered another bug in the implementation, which I have a fix for (and a test for) in review right now. https://chromium-review.googlesource.com/c/v8/v8/+/837641

Since chromium tests change so quickly, I'll need to land another NeedsManualRebaseline patch in chromium before the flag can be enabled by default in v8.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a589f688e818fc84a2a44fffe3a40dcc68e3b4d

commit 0a589f688e818fc84a2a44fffe3a40dcc68e3b4d
Author: Daniel Ehrenberg <littledan@chromium.org>
Date: Wed Dec 27 16:48:29 2017

Revert "NeedsManualRebaseline for --harmony-function-tostring"

This reverts commit 585ea5f5a377015a4b600a02170fa6ff4740a73e.

Reason for revert: A bug was discovered in the --harmony-function-tostring implementation. While the fix is being developed, revert the NeedsManualRebaseline so that any new test failures are caught.

Original change's description:
> NeedsManualRebaseline for --harmony-function-tostring
> 
> Bug:  chromium:753073 
> Change-Id: Iab9e4f4f0a8d09b1d4da0ccd7c27cde49f5bb7b7
> Reviewed-on: https://chromium-review.googlesource.com/695801
> Commit-Queue: Josh Wolfe <jwolfe@igalia.com>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524830}

TBR=chrishtr@chromium.org,littledan@chromium.org,jwolfe@igalia.com

Change-Id: Ia2e3fdaf32f1fa0d3f3a253e7d558ae6e1e15e4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:753073 
Reviewed-on: https://chromium-review.googlesource.com/844574
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526227}
[modify] https://crrev.com/0a589f688e818fc84a2a44fffe3a40dcc68e3b4d/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d04924629b298ca2ee10d32eba25b5f035ffc59

commit 2d04924629b298ca2ee10d32eba25b5f035ffc59
Author: Josh Wolfe <jwolfe@igalia.com>
Date: Wed Jan 10 16:34:54 2018

NeedsManualRebaseline for v8's --harmony-function-tostring

Bug:  chromium:753073 
Change-Id: I0e94bd27e85beca4726aba78b18d8a898cc2eb82
Reviewed-on: https://chromium-review.googlesource.com/834758
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Josh Wolfe <jwolfe@igalia.com>
Cr-Commit-Position: refs/heads/master@{#528339}
[modify] https://crrev.com/2d04924629b298ca2ee10d32eba25b5f035ffc59/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by adamk@chromium.org, Jan 30 2018

Cc: -robertma@chromium.org
Components: Blink>JavaScript>Language
Labels: -Pri-3 -TE-NeedsTriageHelp Pri-2
Owner: adamk@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b031b933104a801a99ccdf403c327a128eb4d065

commit b031b933104a801a99ccdf403c327a128eb4d065
Author: Robert Ma <robertma@chromium.org>
Date: Wed Jan 31 21:52:07 2018

Rebaseline WPT tests after harmony-function-tostring

Bug:  753073 
Change-Id: Ic1d9a73d7b43598008c312d7a8c47cf8b7740901
Reviewed-on: https://chromium-review.googlesource.com/874802
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533428}
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.create2.nonfinite-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.get.nonfinite-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.object.ctor.array.bounds-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.put.nonfinite-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-constructor-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/FileAPI/file/File-constructor-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/cors/allow-headers-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/cors/origin-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/css/geometry/DOMPoint-001-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/dom/collections/HTMLCollection-supported-property-indices-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/domparsing/innerhtml-01-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/eventsource/eventsource-constructor-url-bogus-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/fetch/api/headers/headers-record-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-domain.sub-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/editing/dnd/synthetic/001-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/interfaces/TrackEvent/createEvent-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-canvas-element/imagedata-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-form-element/form-indexed-element-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/pixel-manipulation/2d.imageData.create2.nonfinite-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/pixel-manipulation/2d.imageData.get.nonfinite-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/pixel-manipulation/2d.imageData.put.nonfinite-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.commit-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/payment-request/rejects_if_not_active.https-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/screen-orientation/lock-bad-argument-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/selection/removeRange-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/uievents/legacy/Event-subclasses-init-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/url/historical.any-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/url/historical.any.worker-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/user-timing/invoke_with_timing_attributes-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/web-nfc/nfc_push.https-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/web-nfc/nfc_watch.https-expected.txt
[delete] https://crrev.com/980932f107a644a5e0bc041f9c1dbc0cb2d14a0d/third_party/WebKit/LayoutTests/external/wpt/webstorage/storage_string_conversion-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/workers/interfaces/WorkerUtils/importScripts/002.worker-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/xhr/open-url-multi-window-2-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/xhr/open-url-multi-window-3-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/xhr/open-url-multi-window-5-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/external/wpt/xhr/open-url-multi-window-6-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/platform/linux/external/wpt/url/url-constructor-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/platform/mac/external/wpt/url/url-constructor-expected.txt
[modify] https://crrev.com/b031b933104a801a99ccdf403c327a128eb4d065/third_party/WebKit/LayoutTests/platform/win/external/wpt/url/url-constructor-expected.txt

Comment 9 by adamk@chromium.org, Jan 31 2018

Blockedon: 802400 801556 807192
Cc: robertma@chromium.org
Unfortunately I may have to mark these for rebaselining again, as there are a variety of regressions related to this flag and it may have to be turned off again (see blocking bugs).

Comment 10 by robertma@chromium.org, Jan 31 2018 

adamk@ oh well, then please revert my CL above... (https://chromium-review.googlesource.com/874802)

Comment 11 by l...@chromium.org, Jan 31 2018

Cc: l...@chromium.org

Comment 12 by adamk@chromium.org, Jan 31 2018 

@robertma, I think it may be OK to have these as-is for now; my current plan is to revert the flag on the v8 M65 branch and attempt to fix the regressions before the next branch point. In the meantime, it's good to maintain coverage of those tests, so I thank you for rebasing them.

Comment 13 by raphael....@intel.com, Feb 1 2018

Blocking: 651774

Comment 14 by adamk@chromium.org, Feb 12 2018

Status: Started (was: Assigned)
The remaining blockers on the v8 side are resolved, so I've sent out a patch (https://crrev.com/c/914728) to rebaseline the remaining tests.
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c340949cf8f166c74fc234502983671381fba3c

commit 7c340949cf8f166c74fc234502983671381fba3c
Author: Adam Klein <adamk@chromium.org>
Date: Mon Feb 12 22:46:23 2018

Rebaseline layout tests affected by v8's --harmony-function-tostring flag

It is now on-by-default (and aimed for launch in M66).

Bug:  753073 
Change-Id: Iba7cc4eeeb6aae142498de7d1afc70175cf3838e
Reviewed-on: https://chromium-review.googlesource.com/914728
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536221}
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/dom/TreeWalker/acceptNode-filter-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/dom/Window/anonymous-slot-with-changes-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/events/message-port-multi-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/js/JSON-parse-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/js/function-names-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/js/function-prototype-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/js/function-prototype.html
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/js/script-tests/function-names.js
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/fast/js/toString-and-valueOf-override-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/http/tests/security/window-named-proto-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/http/tests/security/xss-exception-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/storage/domstorage/localstorage/string-conversion-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/storage/domstorage/sessionstorage/string-conversion-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/storage/indexeddb/structured-clone-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/7c340949cf8f166c74fc234502983671381fba3c/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c05b7a3040b2fdb2d3430d56cbdd82d6c42f8458

commit c05b7a3040b2fdb2d3430d56cbdd82d6c42f8458
Author: Adam Klein <adamk@chromium.org>
Date: Fri Mar 02 02:51:36 2018

Remove stale NeedsManualRebaselines from root-layer-scrolling expectations

These tests have long-since been rebaselined, and appear to have been
accidentally left in this file.

Bug:  753073 
Change-Id: If94dc36a4e57532211f3fb608992c80f94de1fe2
Reviewed-on: https://chromium-review.googlesource.com/945136
Commit-Queue: Adam Klein <adamk@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540424}
[modify] https://crrev.com/c05b7a3040b2fdb2d3430d56cbdd82d6c42f8458/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling

Comment 17 by adamk@chromium.org, Mar 2 2018

Status: Fixed (was: Started)
►

Sign in to add a comment