New issue
Advanced search Search tips

Issue 753022 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
STS
Team-Accessibility



Sign in to add a comment

[Select to Speak] Issues with verbalization

Project Member Reported by lpalmaro@chromium.org, Aug 7 2017

Issue description

OS: Chrome

Reported from user in Chrome OS 60: Select to Speak pauses and lowers its tone as though completing a sentence at the end of each line. Sentences that span multiple lines don't read like sentences. Similarly, italics and hyperlinks cause it to pause as though at the end of a sentence.
 
 
Owner: ----
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d3e71fb59c8604bb910479078439dfb0992e27

commit c8d3e71fb59c8604bb910479078439dfb0992e27
Author: Katie Dektar <katydek@google.com>
Date: Fri Oct 13 22:33:56 2017

Smoothly speak paragraphs of text with Select-to-Speak.

Also adds a verbosity setting for logging, since it was very
noisy.

Bug:  753022 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ida2a63ce84738cfe83f6095cdaebf9576c3ac6ff
Reviewed-on: https://chromium-review.googlesource.com/717417
Commit-Queue: Katie Dektar <katydek@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508852}
[modify] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[modify] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp
[modify] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
[add] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils.js
[add] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils_unittest.gtestjs
[modify] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/browser/resources/chromeos/select_to_speak/test_support.js
[modify] https://crrev.com/c8d3e71fb59c8604bb910479078439dfb0992e27/chrome/test/data/webui/BUILD.gn

Comment 3 by katydek@google.com, Oct 13 2017

Owner: katydek@google.com
Status: Started (was: Available)
Labels: STS
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a555ab3ff8a4e7ce2d9ab480194e4fe89359b7

commit 42a555ab3ff8a4e7ce2d9ab480194e4fe89359b7
Author: Katie Dektar <katydek@google.com>
Date: Tue Oct 17 06:19:12 2017

Smoothly speak non-paragraph inline items.

Don't highlight whitespace-only nodes.

Bug:  753022 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaac62b135512ba95ea6dfaabc9450802e939e621
Reviewed-on: https://chromium-review.googlesource.com/719763
Commit-Queue: Katie Dektar <katydek@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509298}
[modify] https://crrev.com/42a555ab3ff8a4e7ce2d9ab480194e4fe89359b7/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils.js
[modify] https://crrev.com/42a555ab3ff8a4e7ce2d9ab480194e4fe89359b7/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils_unittest.gtestjs

Comment 6 by katydek@google.com, Oct 17 2017

Cc: lpalmaro@chromium.org
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 64.0.3262.2
Components: UI>Accessibility>SelectToSpeak
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future. 

Sign in to add a comment