New issue
Advanced search Search tips

Issue 753017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

don't allow persistent video mode and overlays

Project Member Reported by liber...@chromium.org, Aug 7 2017

Issue description

persistent video mode doesn't support dialog-based overlays yet.

exit overlays if we enter persistent video mode, and don't allow entering persistent video mode for secure overlays since we can't fall back.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d57bc416d10d604a440a943bb6cc736c412a3984

commit d57bc416d10d604a440a943bb6cc736c412a3984
Author: liberato@chromium.org <liberato@chromium.org>
Date: Wed Aug 09 20:30:11 2017

Don't create overlays in persistent video mode.

Since persistent video mode doesn't support dialog-based overlays,
this CL makes DialogOverlayImpl fail to initialize if it detects
that the WebContents is in persistent video mode.

This has the side-effect of falling back to SurfaceTexture when
entering persistent video mode, since overlay promotion happens to
fail during the transition.  We need a more robust solution, but
this is functional for now.

Bug:  753017 
Change-Id: Ic3bc8eb378fdfc2a583108372bac4ac01a79de8b
Reviewed-on: https://chromium-review.googlesource.com/608915
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493125}
[modify] https://crrev.com/d57bc416d10d604a440a943bb6cc736c412a3984/content/browser/android/dialog_overlay_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment