ios-simulator fails to upload some test results (uploaded file is missing required num_failures_by_type field) |
||||||||
Issue descriptionios-simulator fails to upload some test results (uploaded file is missing required num_failures_by_type field) Input JSON file probably has full json results format Uploading JSON files for builder "ios-simulator-iPhone 6s Plus-10.0" to server "test-results.appspot.com" INFO:root:Sending request to https://test-results.appspot.com/testfile/upload at 2017-08-02 06:55:33.324604 UTC Traceback (most recent call last): File "/b/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 200, in <module> sys.exit(main(sys.argv[1:])) File "/b/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 195, in main options.test_results_server, attrs, files, 120) File "/b/build/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 51, in upload_test_results timeout_secs) File "/b/build/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 135, in _retry_exp_backoff % (e.code, e.filename, e.read())) test_results_uploader.PermanentError: Received HTTP status 400 loading "https://test-results.appspot.com/testfile/upload": uploaded file is missing required num_failures_by_type field step returned non-zero exit code: 1 Please see the following example: https://luci-milo.appspot.com/buildbot/tryserver.chromium.mac/ios-simulator/271394 ; https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-simulator%2F271394%2F%2B%2Frecipes%2Fsteps%2FUpload_to_test-results__ios_web_view_inttests_%2F0%2Fstdout
,
Aug 16 2017
+jbudorick@, smut@, sergiyb@ because they were involved in discussions around this previously. This issue prevents ios test results from being shown in the flakiness dashboard (there was a long email thread months ago about this). Is this something your team cares about, or should we not care about the missing results?
,
Aug 16 2017
I'd like results for everything (upstream) in test-results, and that definitely goes for bots on the chromium CQ like ios-simulator.
,
Aug 16 2017
https://luci-milo.appspot.com/buildbot/tryserver.chromium.mac/ios-simulator/271394 Step 285 is the failing step, it says num_failures_by_type is missing. Check step 284 above it, which is the test run that generates the JSON. Click on "test data" to open the isolate file browser, then click on "full_results.json". Looks like "num_failures_by_type" is there to me.
,
Aug 17 2017
test-results-hrd logs show a lot of 400s with this missing num_failures_by_type error. All of them appear to be coming from tryserver.chromium.mac builders. The error comes from this line: https://cs.chromium.org/chromium/infra/go/src/infra/appengine/test-results/model/aggregate_result.go?type=cs&q=%22uploaded+file+is+missing+required%22+file:%5Einfra/+package:%5Echromium$&l=258 AggregateResult apparently implements its own UnmarshalJSON: https://cs.chromium.org/chromium/infra/go/src/infra/appengine/test-results/model/aggregate_result.go?type=cs&q=%22uploaded+file+is+missing+required%22+file:%5Einfra/+package:%5Echromium$&l=258
,
Aug 17 2017
,
Aug 17 2017
,
Aug 17 2017
Does that mean we need to update to the AggregateResult format?
,
Dec 22 2017
Moved all Infra>Client>iOS bugs to Infra>Client>Chrome + OS-iOS.
,
Dec 22 2017
FWIW, This particular 400 error message stopped happening for tryserver.chromium.mac some time around August 25th or 26th. 26th: https://bigquery.cloud.google.com/results/test-results-hrd:bquijob_701bfc2f_1607bd89ca2 Change the table suffix to check the previous or following days, but it doesn't seem to happen again after the 26th. Are you still experiencing other symptoms of this problem?
,
Dec 22 2017
,
Dec 27 2017
Thanks for the info! The issue is not seen anymore. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by seanmccullough@chromium.org
, Aug 16 2017