ash: Add a method like GetPrimaryUserPrefService() |
||||||
Issue descriptionSonny needs this for a bluetooth setting feature, see issue 741962. Depending on the timing of that feature we might want to implement this with a delegate back to chrome. For mash, this could probably be done as part of issue 752993 "mash: Maintain a PrefService for every profile in a multiprofile session"
,
Aug 7 2017
,
Sep 8 2017
,
Oct 10 2017
,
Oct 11 2017
@jamescook is this still needed? The BT feature appears to have landed
,
Oct 11 2017
The BT pref feature has landed but with quirks. It would be cleaner if GetPrimaryUserPrefService() is supported by ash.
,
Oct 11 2017
I suspect you could handle this by combining SessionController::GetPrimaryUserSession() and GetUserPrefServiceForUser(). If it's only needed in one place (BT) I would just use the two methods as needed. If it's needed elsewhere I would add a utility method to SessionController for it.
,
Oct 11 2017
Oh, is using GetPrimaryUserSession and GetUserPrefServiceForUser mash-friendly too?
,
Oct 12 2017
Yes.
,
Oct 12 2017
Okay, then GetPrimaryUserPrefService is not needed. Thanks for the advice!
,
Oct 12 2017
Sounds like there is an appropriate avenue for this at present. We can revisit if more callsites need a similar pattern in the future.
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Aug 7 2017