New issue
Advanced search Search tips

Issue 753004 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

RPM build script should verify package dependencies

Project Member Reported by thestig@chromium.org, Aug 7 2017 
Both the .deb and .rpm package generation scripts previously only checked the chrome binary to make sure it has the expected dependencies. The scripts did not check the generated installer packages to make sure they had the right dependencies. This led to  bug 726858 , where we fixed the dependencies and added a verification step.

We should do the same for RPM packages.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0686b193dd649e2b65dcb7aacef423f3ef062d0f

commit 0686b193dd649e2b65dcb7aacef423f3ef062d0f
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Aug 09 07:19:12 2017

Linux: Sanity check RPM package dependencies.

BUG= 753004 

Change-Id: Ibf62cc81d36ebb744ec1b5913ef55d248b1df675
Reviewed-on: https://chromium-review.googlesource.com/606973
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492880}
[modify] https://crrev.com/0686b193dd649e2b65dcb7aacef423f3ef062d0f/chrome/installer/linux/debian/build.sh
[modify] https://crrev.com/0686b193dd649e2b65dcb7aacef423f3ef062d0f/chrome/installer/linux/rpm/build.sh

Comment 2 by thestig@chromium.org, Aug 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment