ld: warning: instance method 'usernameField' … overrides method from class |
||
Issue description
When I build, I see this linker warning:
ld: warning: instance method 'usernameField' in category from obj/chrome/browser/ui/libui.a(passwords_list_view_controller.o) overrides method from class in obj/chrome/browser/ui/libui.a(passwords_list_view_controller.o)
I believe this is from r492289. Can't make irmakk@ the owner, so assigning to vasilii@.
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8befbb64e6be2138dfb054ec372e9af9eeeae24f commit 8befbb64e6be2138dfb054ec372e9af9eeeae24f Author: Irmak Kavasoğlu <irmakk@google.com> Date: Tue Aug 08 09:50:37 2017 Fixed warning : instance method 'usernameField' overrides method from class I've forgotten to remove the existing getter from the test version of the PendingPasswordItemView after adding the getter to the original class. Fixed. Bug: 752995 Change-Id: I6e9b8736b401fe88f1f3f87a01dea1fcddca0b83 Reviewed-on: https://chromium-review.googlesource.com/605227 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#492578} [modify] https://crrev.com/8befbb64e6be2138dfb054ec372e9af9eeeae24f/chrome/browser/ui/cocoa/passwords/password_item_views.h [modify] https://crrev.com/8befbb64e6be2138dfb054ec372e9af9eeeae24f/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm
,
Aug 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by irmakk@google.com
, Aug 8 2017