New issue
Advanced search Search tips

Issue 752987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: 2018-01-22
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 496282



Sign in to add a comment

Remove dezippering from OscillatorNode

Project Member Reported by rtoy@chromium.org, Aug 7 2017

Issue description

The OscillatorNode performs de-zippering when an AudioParam is set directly. The spec doesn't allow de-zippering anymore.
 

Comment 1 by rtoy@chromium.org, Sep 7 2017

Summary: Remove dezippering from OscillatorNode (was: Remove de-zippering from OscillatorNode)

Comment 2 by rtoy@chromium.org, Sep 11 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 3 by rtoy@chromium.org, Jan 4 2018

NextAction: 2018-01-22
The NextAction date has arrived: 2018-01-22
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96bea082bf639b77ca3d952f06f9c86ed81ac234

commit 96bea082bf639b77ca3d952f06f9c86ed81ac234
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Jan 29 23:43:38 2018

Remove Dezippering from OscillatorNode

Remove dezippering from the frequency and detune attributes. The values
are changed immediately instead of gradually changing from the old
value to the new.

Chromium Feature: https://www.chromestatus.com/features/5287995770929152
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ

Bug:  752987 
Test: Oscillator/dezipper.html
Change-Id: I58df869ca99a24f6429c9cc50c1af2101dbdf03d
Reviewed-on: https://chromium-review.googlesource.com/609095
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532663}
[add] https://crrev.com/96bea082bf639b77ca3d952f06f9c86ed81ac234/third_party/WebKit/LayoutTests/webaudio/Oscillator/no-dezippering.html
[modify] https://crrev.com/96bea082bf639b77ca3d952f06f9c86ed81ac234/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

Comment 6 by rtoy@chromium.org, Jan 30 2018

Status: Fixed (was: Started)

Sign in to add a comment