New issue
Advanced search Search tips

Issue 752986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: 2018-01-22
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 496282



Sign in to add a comment

Remove dezippering from BiquadFilterNode

Project Member Reported by rtoy@chromium.org, Aug 7 2017

Issue description

The BiquadFilterNode performs de-zippering when the parameters are set.  This de-zippering needs to be removed since the spec doesn't allow that anymore.
 

Comment 1 by rtoy@chromium.org, Sep 11 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)
Summary: Remove dezippering from BiquadFilterNode (was: Remove de-zippering from BiquadFilterNode)

Comment 2 by rtoy@chromium.org, Jan 4 2018

NextAction: 2018-01-22
The NextAction date has arrived: 2018-01-22
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc

commit 53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Jan 30 16:36:39 2018

Remove Dezippering from BiquadFilter

Remove dezippering from all of the attributes.  The value will now 
change immediately instead of gradually changing from the old value
to the new value.

Chromium Feature: https://www.chromestatus.com/features/5287995770929152
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ

Bug:  752986 
Test: BiquadFilter/dezipper.html
Change-Id: I86840159709158fd52a69a7c3c5f279267277d44
Reviewed-on: https://chromium-review.googlesource.com/612104
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532910}
[add] https://crrev.com/53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/no-dezippering.html
[modify] https://crrev.com/53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp
[modify] https://crrev.com/53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc/third_party/WebKit/Source/platform/audio/Biquad.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff1eda6702d107c98148aded80cb263211e2fa4e

commit ff1eda6702d107c98148aded80cb263211e2fa4e
Author: Samuel Huang <huangs@chromium.org>
Date: Tue Jan 30 18:30:12 2018

Revert "Remove Dezippering from BiquadFilter"

This reverts commit 53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc.

Reason for revert: The new test webaudio/BiquadFilter/no-dezippering.html is failing under Mac 10.10.

Original change's description:
> Remove Dezippering from BiquadFilter
> 
> Remove dezippering from all of the attributes.  The value will now 
> change immediately instead of gradually changing from the old value
> to the new value.
> 
> Chromium Feature: https://www.chromestatus.com/features/5287995770929152
> Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ
> 
> Bug:  752986 
> Test: BiquadFilter/dezipper.html
> Change-Id: I86840159709158fd52a69a7c3c5f279267277d44
> Reviewed-on: https://chromium-review.googlesource.com/612104
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532910}

TBR=rtoy@chromium.org,hongchan@chromium.org

Change-Id: I30c98f8aad3c8a1f7df22e55912a4f86d94d7dfa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  752986 
Reviewed-on: https://chromium-review.googlesource.com/893531
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532957}
[delete] https://crrev.com/b424a5928cba52e245774dd481c39ff36ebaefae/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/no-dezippering.html
[modify] https://crrev.com/ff1eda6702d107c98148aded80cb263211e2fa4e/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/ff1eda6702d107c98148aded80cb263211e2fa4e/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp
[modify] https://crrev.com/ff1eda6702d107c98148aded80cb263211e2fa4e/third_party/WebKit/Source/platform/audio/Biquad.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ac9a286c61c4f5492217f7dd09efb68ec96f63f

commit 8ac9a286c61c4f5492217f7dd09efb68ec96f63f
Author: Raymond Toy <rtoy@chromium.org>
Date: Wed Jan 31 17:44:30 2018

Reland "Remove Dezippering from BiquadFilter"

This is a reland of 53b1b7dad08d9b5e60157f47f2dc195c0d73d4dc.

Original change's description:
> Remove Dezippering from BiquadFilter
> 
> Remove dezippering from all of the attributes.  The value will now 
> change immediately instead of gradually changing from the old value
> to the new value.
> 
> Chromium Feature: https://www.chromestatus.com/features/5287995770929152
> Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ
> 
> Bug:  752986 
> Test: BiquadFilter/dezipper.html
> Change-Id: I86840159709158fd52a69a7c3c5f279267277d44
> Reviewed-on: https://chromium-review.googlesource.com/612104
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532910}

Bug:  752986 
Change-Id: Ia911c6e93d7dd7da1dea6290ac4201f81f42da3a
Reviewed-on: https://chromium-review.googlesource.com/894243
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533314}
[add] https://crrev.com/8ac9a286c61c4f5492217f7dd09efb68ec96f63f/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/no-dezippering.html
[modify] https://crrev.com/8ac9a286c61c4f5492217f7dd09efb68ec96f63f/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/8ac9a286c61c4f5492217f7dd09efb68ec96f63f/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp
[modify] https://crrev.com/8ac9a286c61c4f5492217f7dd09efb68ec96f63f/third_party/WebKit/Source/platform/audio/Biquad.cpp

Comment 7 by rtoy@chromium.org, Feb 1 2018

Status: Fixed (was: Started)

Sign in to add a comment