System profile proto may report min_ect as unknown if there was a connection change |
|||
Issue descriptionSystem profile proto may report min_ect as unknown if there was a connection change. When there is a connection change (e.g., from WiFi to cellular), network change notifier briefly reports connection type as offline. This causes NQE to briefly report ECT as offline. This, in turn, causes the min_ect to be set to UNKNOWN in the corresponding UMA report. This happens in a large percentage of UMA reports because connection changes are common on mobile platforms. If the min_ect is set to UNKNOWN, it makes it difficult to slice the metrics by min_ect in the UMA dashboard. This should be fixed: min_ect should not be set to unknown if there was a connection change event.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d1340e2e352246f61b93994e99175fd35c6090d commit 3d1340e2e352246f61b93994e99175fd35c6090d Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Aug 09 22:11:34 2017 Do not report min_ect as UNKNOWN if the connection type changes to OFFLINE Bug: 752962 Change-Id: I285effcafd51c243cfe5f1fa80310138087a8606 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/603074 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#493159} [modify] https://crrev.com/3d1340e2e352246f61b93994e99175fd35c6090d/components/metrics/net/network_metrics_provider.cc [modify] https://crrev.com/3d1340e2e352246f61b93994e99175fd35c6090d/components/metrics/net/network_metrics_provider.h [modify] https://crrev.com/3d1340e2e352246f61b93994e99175fd35c6090d/components/metrics/net/network_metrics_provider_unittest.cc [modify] https://crrev.com/3d1340e2e352246f61b93994e99175fd35c6090d/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/3d1340e2e352246f61b93994e99175fd35c6090d/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/3d1340e2e352246f61b93994e99175fd35c6090d/net/nqe/network_quality_estimator_test_util.h
,
Aug 14 2017
,
Aug 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bengr@chromium.org
, Aug 8 2017