New issue
Advanced search Search tips

Issue 752952 link

Starred by 1 user
Status: Fixed
Owner:
rajendrant@chromium.org
Closed: Aug 2017
Cc:
etienneb@chromium.org
tbansal@chromium.org
erikc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Potential memory leak in ChromeDataUseAscriber

Project Member Reported by etienneb@chromium.org, Aug 7 2017 
These results are produced by running an chrome extension that randomly browse the web for multiple days. Chrome is running with native-heap-profiling activated and memory allocations are tracked.

The attached stackframes shows where the leaking memory got allocated.
bug1.png
48.7 KB View Download
bug2.png
48.7 KB View Download

Comment 1 by etienneb@chromium.org, Aug 16 2017 

This leak is still showing up in recent trace:

os-arch: "x86_64",
os-name: "Windows NT",
revision: "cdd15784955039742fe9a8235581922d41b82d78-refs/heads/master@{#492239}",
product-version: "Chrome/62.0.3178.0",

See attached file.
bug1.png
38.4 KB View Download

Comment 2 by etienneb@chromium.org, Aug 16 2017

Cc: rajendrant@chromium.org
rajendrant@: could you take a look or re-assign this.

Comment 3 by etienneb@chromium.org, Aug 16 2017 

After a week of intensive random web browsing:

 "content/browser/renderer_host"
    4 x 124294 objects are leaked.
    36791024 + 7954816 + 5966112 + 5966112 = 56M bytes leaked.

Comment 4 by rajendrant@chromium.org, Aug 16 2017

Cc: -rajendrant@chromium.org tbansal@chromium.org
Owner: rajendrant@chromium.org
Status: Assigned (was: Untriaged)
I will look into.

Comment 5 by etienneb@chromium.org, Aug 24 2017 

Any progress on this bug?
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a39e2860b5092ed4c1ccdadf884896c0bbca569c

commit a39e2860b5092ed4c1ccdadf884896c0bbca569c
Author: rajendrant <rajendrant@chromium.org>
Date: Mon Aug 28 21:38:59 2017

Do not create recorder on URL request destroy

New DataUseRecorder need not be created in OnURLRequestDestroyed. It is created
only in OnBeforeURLRequest().

Bug:  752952 
Change-Id: Iebe0ad54b77de6591e803974ddffc4fc11e88e34
Reviewed-on: https://chromium-review.googlesource.com/638851
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497887}
[modify] https://crrev.com/a39e2860b5092ed4c1ccdadf884896c0bbca569c/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/a39e2860b5092ed4c1ccdadf884896c0bbca569c/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h

Comment 7 by rajendrant@chromium.org, Aug 28 2017

Components: Internals>Network>DataUse
Status: Fixed (was: Assigned)
►

Sign in to add a comment