Background Fetch now uses `id` where it previously used `tag` in its Web exposed identifiers. `getTags` has been renamed to `getIds`. https://github.com/WICG/background-fetch/commit/15dd317bbb2e2c7da12ebb11de547e635e59969f We should update our implementation to match. This may cause a backwards compatibility breakage, but since we're still in development that's OK. Better to do it now than after more people adopt the spec. (I'll send a PR to https://github.com/GoogleChrome/sample-media-pwa.)
PR for the sample PWA is available here: https://github.com/GoogleChrome/sample-media-pwa/pull/24 We need to ping it once the rename hits Canary.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5ae7f85db726f86d88d14a35dceefe4814cf15e commit d5ae7f85db726f86d88d14a35dceefe4814cf15e Author: Dan Elphick <delphick@chromium.org> Date: Wed Aug 09 09:42:17 2017 Rename tag to id in BackgroundFetchRegistration Matches recent change to spec: https://github.com/WICG/background-fetch/commit/15dd317bbb2e2c7da12ebb11de547e635e59969f Bug: 752946 Change-Id: I4065564d79dd8a0d7aad5c7f49f6d87288e3b4f5 Reviewed-on: https://chromium-review.googlesource.com/603654 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#492924} [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_registration_id.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_registration_id.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_service_impl.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_service_impl.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/browser/bad_message.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/common/background_fetch/background_fetch_struct_traits_unittest.cc [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/common/background_fetch/background_fetch_types.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/interfaces-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/interfaces-worker.https-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/interfaces.idl [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/external/wpt/background-fetch/interfaces.worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-fail-event.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-getTags.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetched-event.https.html [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-event-worker.js [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.idl [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEventInit.idl [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchTypeConverters.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/d5ae7f85db726f86d88d14a35dceefe4814cf15e/tools/metrics/histograms/enums.xml
Comment 1 by delph...@chromium.org
, Aug 7 2017Status: Assigned (was: Available)