authpolicy: Detection for bad password is broken |
|||||||||
Issue description
kinit used to return
"Preauthentication failed while getting initial credentials"
but it got changed to
"Password incorrect while getting initial credentials"
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6ce7a731c77091c4def5d2883c4407d51b3d1618 commit 6ce7a731c77091c4def5d2883c4407d51b3d1618 Author: Lutz Justen <ljusten@chromium.org> Date: Tue Aug 08 21:56:12 2017 authpolicy: Fix detection for bad passwords Leads to bad user experience since Chrome couldn't show a proper error message. BUG= chromium:752936 TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy Change-Id: I98b77559e269a22d611614750b0c9f3af31d91f2 Reviewed-on: https://chromium-review.googlesource.com/603793 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/6ce7a731c77091c4def5d2883c4407d51b3d1618/authpolicy/tgt_manager.cc
,
Aug 9 2017
Requestion to merge. This is a product excellence item. Without this, the user won't get proper feedback when they enter the wrong password when Active Directory enrolled (very low user base).
,
Aug 9 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/46fe7f2df2c9300eeb67896d5ba6f4f3bbc29397 commit 46fe7f2df2c9300eeb67896d5ba6f4f3bbc29397 Author: Lutz Justen <ljusten@chromium.org> Date: Thu Aug 10 07:51:30 2017 authpolicy: Fix detection for bad passwords Leads to bad user experience since Chrome couldn't show a proper error message. BUG= chromium:752936 TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy Change-Id: I98b77559e269a22d611614750b0c9f3af31d91f2 Reviewed-on: https://chromium-review.googlesource.com/603793 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> (cherry picked from commit 6ce7a731c77091c4def5d2883c4407d51b3d1618) Reviewed-on: https://chromium-review.googlesource.com/609782 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Trybot-Ready: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/46fe7f2df2c9300eeb67896d5ba6f4f3bbc29397/authpolicy/tgt_manager.cc
,
Aug 14 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 14 2017
,
Aug 29 2017
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ljusten@chromium.org
, Aug 7 2017