The TASK_STACK_SIZE of host board is undefined |
||||||
Issue descriptionThe TASK_STACK_SIZE in board/host/ec.tasklist isn't defined in anywhere. (typically it will be defined in chip/host/config_chip.h) For now the stack sizes of tasks are unused by macros on host, so it's ok. However it will be a problem when the tasklist is referenced from outside for some reasons. e.g. I'm trying to extract the stack sizes of all boards. What is the expected result? Maybe it can be defined as a fake value, like 0, in the config_chip.h?
,
Aug 7 2017
,
Aug 7 2017
,
Aug 7 2017
Yes put whatever "#define TASK_STACK_SIZE" in chip/host/config_chip.h I would have put our standard value 512, but 0 is fine. At least people will realize it's not used as they think.
,
Aug 8 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/02aa4ee1e5d73d65b9aae5915e284a2ff6ceadc6 commit 02aa4ee1e5d73d65b9aae5915e284a2ff6ceadc6 Author: Che-yu Wu <cheyuw@google.com> Date: Tue Aug 08 11:01:44 2017 chip/host/config_chip: Fix TASK_STACK_SIZE of the host board. Define TASK_STACK_SIZE as standard value 512 for the host board. BUG= chromium:752923 BRANCH=none TEST=make runtests Change-Id: I3e5120847e9b14fbf96d00c428b2db9d59d38fe2 Signed-off-by: Che-yu Wu <cheyuw@google.com> Reviewed-on: https://chromium-review.googlesource.com/604850 Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/02aa4ee1e5d73d65b9aae5915e284a2ff6ceadc6/chip/host/config_chip.h
,
Aug 9 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cheyuw@google.com
, Aug 7 2017