New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752910 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Toolbar is shifted down on NTP

Project Member Reported by gambard@chromium.org, Aug 7 2017

Issue description

What steps will reproduce the problem?
(1) Open NTP with ContentSuggestions on
(2) Open tab switcher

What is the expected result?
The fake toolbar at the top should be at the same level as the real one.

What happens instead?
The fake toolbar is slightly shifted down compared to the real one (displayed on the tab switcher).
 

Comment 1 by fi...@chromium.org, Aug 7 2017

Labels: zine-traiged

Comment 2 by fi...@chromium.org, Aug 7 2017

Labels: -zine-traiged zine-triaged
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/034f09fb84756039a913e27ceba7556ad8ffb891

commit 034f09fb84756039a913e27ceba7556ad8ffb891
Author: gambard <gambard@chromium.org>
Date: Tue Aug 08 06:40:42 2017

Fix NTP faketoolbar vertical alignment

The faketoolbar on the NTP is slightly shifted down.
This CL fixes it by removing the 8pt padding on top of the header.

Bug:  752910 
Change-Id: I976f8098df3f6bc7f3746e4ca7f01d63ed5c0db5
Reviewed-on: https://chromium-review.googlesource.com/603613
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492556}
[modify] https://crrev.com/034f09fb84756039a913e27ceba7556ad8ffb891/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 62.0.3186.0 canary, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11

The fake toolbar at the top seems at the same level as the real one.
https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLaUQ0QS1BQVkwOTA/view

Sign in to add a comment