New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752906 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Aug 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : After resizing, devtools automatically switches from current tab to 'Styles' tab.

Reported by avsha...@etouch.net, Aug 7 2017 
Chrome version : 62.0.3178.0 (Official Build) cdd15784955039742fe9a8235581922d41b82d78-refs/heads/master@{#492239} 32/64 bit
OS : Windows (7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3, 10.12.5)

What steps will reproduce the problem?
1. Launch chrome and open devtools on NTP.
2. In 'Elements' section, click on 'Properties' tab and resize devtools window towards RHS.
3. Observe.

Actual Result : After resizing, current tab disappears and devtools automatically switches to 'Styles' tab.
Expected Result : After resizing, it should stay on current (Properties) tab and should not switch to 'Styles' tab.

This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info.
Good build : 60.0.3102.0
Bad build : 60.0.3103.0
Actual_Result.mp4
1.9 MB View Download
Expected_Result.mp4
1.6 MB View Download

Comment 1 by jmukthavaram@chromium.org, Aug 7 2017

Cc: jmukthavaram@chromium.org
Labels: hasbisect
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using chrome latest version-62.0.3178.0.
Manual bisect info:
-------------------
Good build : 60.0.3101.0-Revision-471958
Bad build : 60.0.3103.0-Revision- 472587

Unable to provide bisect with new script for the above range. Hence providing bisect with old script:
Bisect tool info:
----------------
You are probably looking for a change made after 472256 (known good), but no later than 472271 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/3948d50a08e75cd127eea4ae47267adeb1d945bf..ef6dbc9d6646289f515bfd627ee84b971a86c8d4

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/eba1e6e57e86f481a3b5a40713a744ce3d9f2d66

luoe@,Could you please take a look and reassign to the right owner if it is not related to your change.
Thanks..!!

Comment 2 by l...@chromium.org, Aug 7 2017 

Thanks for the report.  Indeed, losing the selected tab when resizing to a smaller width is due to my change.  There's a similar bug on stable, where resizing to a larger width will lose the selected tab, which is a non-regression.  I'll take a look.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0408391105df5ba82af54510233e662b2af60ef

commit f0408391105df5ba82af54510233e662b2af60ef
Author: Erik Luo <luoe@chromium.org>
Date: Tue Aug 08 01:02:12 2017

DevTools: preserve selected tab when resizing elements panel

The Elements panel sidebar can be resized to one of 3 layouts. After
switching, the tabbedPane is recreated, causing the first tab to be
selected. Instead of losing the last selected tab, this CL preserves it
if possible, upon resize.

Bug:  752906 
Change-Id: Ie44005c830e8ab57e33849509ac46bf57fc8dcc9
Reviewed-on: https://chromium-review.googlesource.com/604233
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492482}
[modify] https://crrev.com/f0408391105df5ba82af54510233e662b2af60ef/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Comment 4 by avsha...@etouch.net, Aug 10 2017

Labels: TE-Verified-M62 TE-Verified-62.0.3181.0
Update :
Tested above issue in latest Canary #62.0.3181.0 build on Windows(7,8,10), Linux(14.04) & Mac OS and the issue is fixed. Now it preserves current tab when resizing devtools and the fix is working as intended.

Thank you!
Canary_Behaviour.mp4
1.2 MB View Download

Comment 5 by l...@chromium.org, Aug 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment