New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752900 link

Starred by 1 user
Status: Fixed
Owner:
tapted@chromium.org
Closed: Aug 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 740827



Sign in to add a comment

Regression: Focus highlight is missing on 'Secure' button after opening Allow/block bubble..

Reported by db...@etouch.net, Aug 7 2017 
Chrome Version: Chrome Version:62.0.3178.0 (Official Build) cdd15784955039742fe9a8235581922d41b82d78-refs/heads/master@{#492239}(64 bit). 

OS: Mac(10.11.6,10.12.3),Windows(7,8,10), Linux(14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to https://permission.site/
(2) Click on 'Location', observe focus highlight on Secure after opening allow/block bubble.

Actual: Focus highlight is missing on Secure button.

Expected: Focus highlight should be seen.

This is Regression issue broken in M-62 and will soon update other bisect info.

Manual Bisect Info:
Good Build: 62.0.3166.0
Bad Build: 62.0.3168.0
Actual_Focus.mov
2.1 MB Download
Expected_Focus.mov
2.7 MB Download

Comment 1 by jmukthavaram@chromium.org, Aug 7 2017

Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision OS-Linux OS-Windows
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7,Mac & Ubuntu 14.04 using chrome reported version-62.0.3178.0.
Manual bisect info:
-------------------
Good Build: 62.0.3166.0—Revision-489161
Bad Build:  62.0.3168.0 —Revision-489803

Per revision bisect info:
------------------------
You are probably looking for a change made after 489244 (known good), but no later than 489245 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/57fc53b6e72d22dbc04bacafc117e5a58dcef19d..e75db8e47e1b5e84a2f05afbd33f254fe2879f1c

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/e75db8e47e1b5e84a2f05afbd33f254fe2879f1c

tapted@,Could you please look into this & reassign to the right owner if it is not related to your change.
Thanks..!!

Comment 2 by tapted@chromium.org, Aug 8 2017

Blocking: 740827
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/604770
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa87564a2465007e14531df9b0139b6948b9eb1e

commit fa87564a2465007e14531df9b0139b6948b9eb1e
Author: Trent Apted <tapted@chromium.org>
Date: Wed Aug 09 04:04:17 2017

MacViews: Ensure the page info button highlight tracks permission bubbles.

Permission bubbles do their own re-anchoring, so haven't needed a call
to bubble_anchor_helper's KeepBubbleAnchored(). However, they do need
the feature that allows the LocationBarDecoration to properly show a
highlight while the bubble is visible.

Add TrackBubbleState(Bubble, Decoration) to cater for this.

Bug:  752900 
Change-Id: I8650a4155e28b96cfcc15b6e20d18a74424bb372
Reviewed-on: https://chromium-review.googlesource.com/604770
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492818}
[modify] https://crrev.com/fa87564a2465007e14531df9b0139b6948b9eb1e/chrome/browser/ui/cocoa/bubble_anchor_helper_views.h
[modify] https://crrev.com/fa87564a2465007e14531df9b0139b6948b9eb1e/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[modify] https://crrev.com/fa87564a2465007e14531df9b0139b6948b9eb1e/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/fa87564a2465007e14531df9b0139b6948b9eb1e/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/fa87564a2465007e14531df9b0139b6948b9eb1e/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm

Comment 4 by tapted@chromium.org, Aug 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment